GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — stream: fix duplexify premature destroy · nodejs/node@70244d0

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

lib/internal/streams
- duplexify.js
test/parallel
- test-stream-duplex-from.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎lib/internal/streams/duplexify.js‎`

Copy file name to clipboardExpand all lines: lib/internal/streams/duplexify.js

-2Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -262,8 +262,6 @@ function _duplexify(pair) {`
`262`	`262`	`cb(err);`
`263`	`263`	`} else if (err) {`
`264`	`264`	`d.destroy(err);`
`265`		`- } else if (!readable && !writable) {`
`266`		`- d.destroy();`
`267`	`265`	`}`
`268`	`266`	`}`
`269`	`267`

Collapse file

`‎test/parallel/test-stream-duplex-from.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-stream-duplex-from.js

+22-1Lines changed: 22 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`
`3`	`3`	`const common = require('../common');`
`4`	`4`	`const assert = require('assert');`
`5`		`-const { Duplex, Readable, Writable, pipeline } = require('stream');`
	`5`	`+const { Duplex, Readable, Writable, pipeline, PassThrough } = require('stream');`
`6`	`6`	`const { Blob } = require('buffer');`
`7`	`7`
`8`	`8`	`{`
`@@ -278,3 +278,24 @@ const { Blob } = require('buffer');`
`278`	`278`
`279`	`279`	`duplex.write('test');`
`280`	`280`	`}`
	`281`	`+`
	`282`	`+{`
	`283`	`+ const through = new PassThrough({ objectMode: true });`
	`284`	`+`
	`285`	`+ let res = '';`
	`286`	`+ const d = Readable.from(['foo', 'bar'], { objectMode: true })`
	`287`	`+ .pipe(Duplex.from({`
	`288`	`+ writable: through,`
	`289`	`+ readable: through`
	`290`	`+ }));`
	`291`	`+`
	`292`	`+ d.on('data', (data) => {`
	`293`	`+ d.pause();`
	`294`	`+ setImmediate(() => {`
	`295`	`+ d.resume();`
	`296`	`+ });`
	`297`	`+ res += data;`
	`298`	`+ }).on('end', common.mustCall(() => {`
	`299`	`+ assert.strictEqual(res, 'foobar');`
	`300`	`+ })).on('close', common.mustCall());`
	`301`	`+}`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.