GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — src: turn embedder api overload into default argument · nodejs/node@77e5856

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

src
- node.cc
- node.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎src/node.cc‎`

Copy file name to clipboardExpand all lines: src/node.cc

-7Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -862,13 +862,6 @@ int ProcessGlobalArgs(std::vector<std::string>* args,`
`862`	`862`
`863`	`863`	`static std::atomic_bool init_called{false};`
`864`	`864`
`865`		`-int InitializeNodeWithArgs(std::vector<std::string>* argv,`
`866`		`- std::vector<std::string>* exec_argv,`
`867`		`- std::vector<std::string>* errors) {`
`868`		`- return InitializeNodeWithArgs(argv, exec_argv, errors,`
`869`		`- ProcessFlags::kNoFlags);`
`870`		`-}`
`871`		`-`
`872`	`865`	`int InitializeNodeWithArgs(std::vector<std::string>* argv,`
`873`	`866`	`std::vector<std::string>* exec_argv,`
`874`	`867`	`std::vector<std::string>* errors,`

Collapse file

`‎src/node.h‎`

Copy file name to clipboardExpand all lines: src/node.h

+1-6Lines changed: 1 addition & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -250,16 +250,11 @@ NODE_EXTERN int Stop(Environment* env);`
`250`	`250`	`// from argv, fill exec_argv, and possibly add errors resulting from parsing`
`251`	`251`	// the arguments to `errors`. The return value is a suggested exit code for the
`252`	`252`	`// program; If it is 0, then initializing Node.js succeeded.`
`253`		`-NODE_EXTERN int InitializeNodeWithArgs(`
`254`		`- std::vector<std::string>* argv,`
`255`		`- std::vector<std::string>* exec_argv,`
`256`		`- std::vector<std::string>* errors);`
`257`		`-// TODO(zcbenz): Turn above overloaded version into below's default argument.`
`258`	`253`	`NODE_EXTERN int InitializeNodeWithArgs(`
`259`	`254`	`std::vector<std::string>* argv,`
`260`	`255`	`std::vector<std::string>* exec_argv,`
`261`	`256`	`std::vector<std::string>* errors,`
`262`		`- ProcessFlags::Flags flags);`
	`257`	`+ ProcessFlags::Flags flags = ProcessFlags::kNoFlags);`
`263`	`258`
`264`	`259`	`enum OptionEnvvarSettings {`
`265`	`260`	`kAllowedInEnvironment,`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.