GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — test: fix flaky test-child-process-exec-timeout · nodejs/node@7af8738

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

test/parallel
- test-child-process-exec-timeout.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎test/parallel/test-child-process-exec-timeout.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-child-process-exec-timeout.js

+7-1Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -18,7 +18,13 @@ const cmd = `${process.execPath} ${__filename} child`;
`18`	`18`	`cp.exec(cmd, { timeout: 1 }, common.mustCall((err, stdout, stderr) => {`
`19`	`19`	`assert.strictEqual(err.killed, true);`
`20`	`20`	`assert.strictEqual(err.code, null);`
`21`		`- assert.strictEqual(err.signal, 'SIGTERM');`
	`21`	`+ // At least starting with Darwin Kernel Version 16.4.0, sending a SIGTERM to a`
	`22`	`+ // process that is still starting up kills it with SIGKILL instead of SIGTERM.`
	`23`	`+ // See: https://github.com/libuv/libuv/issues/1226`
	`24`	`+ if (common.isOSX)`
	`25`	`+ assert.ok(err.signal === 'SIGTERM' \|\| err.signal === 'SIGKILL');`
	`26`	`+ else`
	`27`	`+ assert.strictEqual(err.signal, 'SIGTERM');`
`22`	`28`	`assert.strictEqual(err.cmd, cmd);`
`23`	`29`	`assert.strictEqual(stdout.trim(), '');`
`24`	`30`	`assert.strictEqual(stderr.trim(), '');`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.