GeezerVison is showing github.com — src: clean up experimental flag variables · nodejs/node@7efc2ce
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: src/api/environment.cc +2-6Lines changed: 2 additions & 6 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -267,13 +267,9 @@ void SetIsolateMiscHandlers(v8::Isolate* isolate, const IsolateSettings& s) { |
267 | 267 | isolate->SetModifyCodeGenerationFromStringsCallback( |
268 | 268 | modify_code_generation_from_strings_callback); |
269 | 269 |
|
270 | | - Mutex::ScopedLock lock(node::per_process::cli_options_mutex); |
271 | | - if (per_process::cli_options->get_per_isolate_options() |
272 | | - ->get_per_env_options() |
273 | | - ->experimental_fetch) { |
274 | | - isolate->SetWasmStreamingCallback(wasm_web_api::StartStreamingCompilation); |
275 | | - } |
| 270 | + isolate->SetWasmStreamingCallback(wasm_web_api::StartStreamingCompilation); |
276 | 271 |
|
| 272 | + Mutex::ScopedLock lock(node::per_process::cli_options_mutex); |
277 | 273 | if (per_process::cli_options->get_per_isolate_options() |
278 | 274 | ->experimental_shadow_realm) { |
279 | 275 | isolate->SetHostCreateShadowRealmContextCallback( |
|
Collapse file
Copy file name to clipboardExpand all lines: src/node_options.cc +1-1Lines changed: 1 addition & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
@@ -605,7 +605,7 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() { |
605 | 605 | "experimental node:sqlite module", |
606 | 606 | &EnvironmentOptions::experimental_sqlite, |
607 | 607 | kAllowedInEnvvar, |
608 | | - true); |
| 608 | + HAVE_SQLITE); |
609 | 609 | AddOption("--experimental-stream-iter", |
610 | 610 | "experimental iterable streams API (node:stream/iter)", |
611 | 611 | &EnvironmentOptions::experimental_stream_iter, |
|
Collapse file
Copy file name to clipboardExpand all lines: src/node_options.h +1-2Lines changed: 1 addition & 2 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -124,10 +124,9 @@ class EnvironmentOptions : public Options { |
124 | 124 | bool enable_source_maps = false; |
125 | 125 | bool experimental_addon_modules = false; |
126 | 126 | bool experimental_eventsource = false; |
127 | | - bool experimental_fetch = true; |
128 | 127 | bool experimental_ffi = false; |
129 | 128 | bool experimental_websocket = true; |
130 | | - bool experimental_sqlite = true; |
| 129 | + bool experimental_sqlite = HAVE_SQLITE; |
131 | 130 | bool experimental_stream_iter = false; |
132 | 131 | bool webstorage = HAVE_SQLITE; |
133 | 132 | bool experimental_quic = false; |
|
Collapse file
Copy file name to clipboardExpand all lines: test/parallel/test-require-resolve.js +1Lines changed: 1 addition & 0 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -64,6 +64,7 @@ require(fixtures.path('resolve-paths', 'default', 'verify-paths.js')); |
64 | 64 | if (mod === 'node:quic') return; |
65 | 65 | // TODO: Remove once node:ffi is no longer flagged |
66 | 66 | if (mod === 'node:ffi') return; |
| 67 | + if (mod === 'node:sqlite' && !common.hasSQLite) return; |
67 | 68 | assert.strictEqual(require.resolve.paths(mod), null); |
68 | 69 | if (!mod.startsWith('node:')) { |
69 | 70 | assert.strictEqual(require.resolve.paths(`node:${mod}`), null); |
|