GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — buffer: allow invalid encoding in from · nodejs/node@84bf93b

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

lib
- buffer.js
test/parallel
- test-buffer-from.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎lib/buffer.js‎`

Copy file name to clipboardExpand all lines: lib/buffer.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -474,7 +474,7 @@ function createFromString(string, ops, length = ops.byteLength(string)) {`
`474`	`474`
`475`	`475`	`function fromString(string, encoding) {`
`476`	`476`	`let ops;`
`477`		`- if (!encoding \|\| encoding === 'utf8') {`
	`477`	`+ if (!encoding \|\| encoding === 'utf8' \|\| typeof encoding !== 'string') {`
`478`	`478`	`ops = encodingOps.utf8;`
`479`	`479`	`} else {`
`480`	`480`	`ops = getEncodingOps(encoding);`

Collapse file

`‎test/parallel/test-buffer-from.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-buffer-from.js

+3Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -139,3 +139,6 @@ throws(() => {`
`139`	`139`	`code: 'ERR_OUT_OF_RANGE',`
`140`	`140`	`})`
`141`	`141`	`);`
	`142`	`+`
	`143`	`+// Invalid encoding is allowed`
	`144`	`+Buffer.from('asd', 1);`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.