GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — stream: fix premature pipeline end · nodejs/node@84d0eb7

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

lib/internal/streams
- pipeline.js
test/parallel
- test-stream-pipeline.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎lib/internal/streams/pipeline.js‎`

Copy file name to clipboardExpand all lines: lib/internal/streams/pipeline.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ const {`
`38`	`38`	`isTransformStream,`
`39`	`39`	`isWebStream,`
`40`	`40`	`isReadableStream,`
`41`		`- isReadableEnded,`
	`41`	`+ isReadableFinished,`
`42`	`42`	`} = require('internal/streams/utils');`
`43`	`43`	`const { AbortController } = require('internal/abort_controller');`
`44`	`44`
`@@ -424,7 +424,7 @@ function pipe(src, dst, finish, { end }) {`
`424`	`424`	`dst.end();`
`425`	`425`	`}`
`426`	`426`
`427`		`- if (isReadableEnded(src)) { // End the destination if the source has already ended.`
	`427`	`+ if (isReadableFinished(src)) { // End the destination if the source has already ended.`
`428`	`428`	`process.nextTick(endFn);`
`429`	`429`	`} else {`
`430`	`430`	`src.once('end', endFn);`

Collapse file

`‎test/parallel/test-stream-pipeline.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-stream-pipeline.js

+28Lines changed: 28 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1634,3 +1634,31 @@ const tsp = require('timers/promises');`
`1634`	`1634`	`assert.strictEqual(writable.closed, false);`
`1635`	`1635`	`}));`
`1636`	`1636`	`}`
	`1637`	`+`
	`1638`	`+{`
	`1639`	`+ const r = new Readable();`
	`1640`	`+ for (let i = 0; i < 4000; i++) {`
	`1641`	`+ r.push('asdfdagljanfgkaljdfn');`
	`1642`	`+ }`
	`1643`	`+ r.push(null);`
	`1644`	`+`
	`1645`	`+ let ended = false;`
	`1646`	`+ r.on('end', () => {`
	`1647`	`+ ended = true;`
	`1648`	`+ });`
	`1649`	`+`
	`1650`	`+ const w = new Writable({`
	`1651`	`+ write(chunk, enc, cb) {`
	`1652`	`+ cb(null);`
	`1653`	`+ },`
	`1654`	`+ final: common.mustCall((cb) => {`
	`1655`	`+ assert.strictEqual(ended, true);`
	`1656`	`+ cb(null);`
	`1657`	`+ })`
	`1658`	`+ });`
	`1659`	`+`
	`1660`	`+ pipeline(r, w, common.mustCall((err) => {`
	`1661`	`+ assert.strictEqual(err, undefined);`
	`1662`	`+ }));`
	`1663`	`+`
	`1664`	`+}`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.