GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: V8: cherry-pick 9ebca66a5740 · nodejs/node@8542ace

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • deps/v8
    • src
      • api
        • api.cc
      • builtins
        • builtins-arraybuffer.cc
      • compiler
        • heap-refs.cc
        • js-call-reducer.cc
        • js-native-context-specialization.cc
      • flags
        • flag-definitions.h
      • heap
        • factory.cc
      • init
        • bootstrapper.cc
      • objects
        • js-array-buffer.cc
        • value-serializer.cc
    • test
      • cctest
        • test-api-array-buffer.cc
      • mjsunit
        • compiler
          • typedarray-resizablearraybuffer.js
        • dataview-growablesharedarraybuffer.js
        • dataview-resizablearraybuffer-detach.js
        • dataview-resizablearraybuffer.js
        • harmony
          • arraybuffer-transfer.js
          • typed-array-to-sorted.js
          • typedarray-to-reversed.js
          • typedarray-tostringtag.js
          • typedarray-with.js
        • maglev
          • regress-1406456.js
          • typedarray-resizablearraybuffer.js
        • rab-gsab-transfer-to-worker.js
        • rab-gsab-valueserializer.js
        • regress-1358505.js
        • regress-crbug-1321980.js
        • regress-crbug-1359991.js
        • regress
          • regress-1380398.js
          • regress-1393942.js
          • regress-crbug-1306929.js
          • regress-crbug-1307310.js
          • regress-crbug-1347721.js
          • regress-crbug-1347722.js
          • regress-crbug-1362487.js
          • regress-crbug-1377840.js
          • regress-crbug-1381064.js
          • regress-crbug-1384474-variant2.js
          • regress-crbug-1384474-variant3.js
          • regress-crbug-1384474.js
          • regress-crbug-1392577.js
          • regress-crbug-1393375.js
          • regress-crbug-1399799.js
          • regress-crbug-1402139.js
          • regress-crbug-1412001.js
          • regress-crbug-1454650.js
          • regress-crbug-1459172.js
        • resizablearraybuffer-growablesharedarraybuffer.js
        • typedarray-growablesharedarraybuffer-array-methods.js
        • typedarray-growablesharedarraybuffer-atomics.js
        • typedarray-growablesharedarraybuffer.js
        • typedarray-resizablearraybuffer-array-methods.js
        • typedarray-resizablearraybuffer-atomics.js
        • typedarray-resizablearraybuffer-detach.js
        • typedarray-resizablearraybuffer.js
        • wasm
          • resizablearraybuffer-growablesharedarraybuffer-wasm.js
      • test262
        • testcfg.py
      • unittests/objects
        • value-serializer-unittest.cc

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Dismiss banner
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎deps/v8/src/api/api.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/api/api.cc
-3Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8953,9 +8953,6 @@ std::unique_ptr<v8::BackingStore> v8::ArrayBuffer::NewBackingStore(
89538953
// static
89548954
std::unique_ptr<BackingStore> v8::ArrayBuffer::NewResizableBackingStore(
89558955
size_t byte_length, size_t max_byte_length) {
8956-
Utils::ApiCheck(i::v8_flags.harmony_rab_gsab,
8957-
"v8::ArrayBuffer::NewResizableBackingStore",
8958-
"Constructing resizable ArrayBuffers is not supported");
89598956
Utils::ApiCheck(byte_length <= max_byte_length,
89608957
"v8::ArrayBuffer::NewResizableBackingStore",
89618958
"Cannot construct resizable ArrayBuffer, byte_length must be "
Collapse file

‎deps/v8/src/builtins/builtins-arraybuffer.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/builtins/builtins-arraybuffer.cc
+9-11Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -134,18 +134,16 @@ BUILTIN(ArrayBufferConstructor) {
134134
}
135135

136136
Handle<Object> number_max_length;
137-
if (v8_flags.harmony_rab_gsab) {
138-
Handle<Object> max_length;
139-
Handle<Object> options = args.atOrUndefined(isolate, 2);
140-
ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
141-
isolate, max_length,
142-
JSObject::ReadFromOptionsBag(
143-
options, isolate->factory()->max_byte_length_string(), isolate));
137+
Handle<Object> max_length;
138+
Handle<Object> options = args.atOrUndefined(isolate, 2);
139+
ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
140+
isolate, max_length,
141+
JSObject::ReadFromOptionsBag(
142+
options, isolate->factory()->max_byte_length_string(), isolate));
144143

145-
if (!IsUndefined(*max_length, isolate)) {
146-
ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
147-
isolate, number_max_length, Object::ToInteger(isolate, max_length));
148-
}
144+
if (!IsUndefined(*max_length, isolate)) {
145+
ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, number_max_length,
146+
Object::ToInteger(isolate, max_length));
149147
}
150148
return ConstructBuffer(isolate, target, new_target, number_length,
151149
number_max_length, InitializedFlag::kZeroInitialized);
Collapse file

‎deps/v8/src/compiler/heap-refs.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/compiler/heap-refs.cc
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1127,7 +1127,7 @@ bool MapRef::CanInlineElementAccess() const {
11271127
(Is64() || (kind != BIGINT64_ELEMENTS && kind != BIGUINT64_ELEMENTS))) {
11281128
return true;
11291129
}
1130-
if (v8_flags.turbo_rab_gsab && IsRabGsabTypedArrayElementsKind(kind) &&
1130+
if (IsRabGsabTypedArrayElementsKind(kind) &&
11311131
kind != RAB_GSAB_BIGUINT64_ELEMENTS &&
11321132
kind != RAB_GSAB_BIGINT64_ELEMENTS) {
11331133
return true;
Collapse file

‎deps/v8/src/compiler/js-call-reducer.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/compiler/js-call-reducer.cc
+2-6Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7552,7 +7552,7 @@ Reduction JSCallReducer::ReduceArrayBufferViewByteLengthAccessor(
75527552
}
75537553
}
75547554

7555-
if (!v8_flags.harmony_rab_gsab || !maybe_rab_gsab) {
7555+
if (!maybe_rab_gsab) {
75567556
// We do not perform any change depending on this inference.
75577557
Reduction unused_reduction = inference.NoChange();
75587558
USE(unused_reduction);
@@ -7561,8 +7561,6 @@ Reduction JSCallReducer::ReduceArrayBufferViewByteLengthAccessor(
75617561
node, JS_TYPED_ARRAY_TYPE,
75627562
AccessBuilder::ForJSArrayBufferViewByteLength(),
75637563
Builtin::kTypedArrayPrototypeByteLength);
7564-
} else if (!v8_flags.turbo_rab_gsab) {
7565-
return inference.NoChange();
75667564
}
75677565

75687566
const CallParameters& p = CallParametersOf(node->op());
@@ -7613,16 +7611,14 @@ Reduction JSCallReducer::ReduceTypedArrayPrototypeLength(Node* node) {
76137611
if (IsRabGsabTypedArrayElementsKind(kind)) maybe_rab_gsab = true;
76147612
}
76157613

7616-
if (!v8_flags.harmony_rab_gsab || !maybe_rab_gsab) {
7614+
if (!maybe_rab_gsab) {
76177615
// We do not perform any change depending on this inference.
76187616
Reduction unused_reduction = inference.NoChange();
76197617
USE(unused_reduction);
76207618
// Call default implementation for non-rab/gsab TAs.
76217619
return ReduceArrayBufferViewAccessor(node, JS_TYPED_ARRAY_TYPE,
76227620
AccessBuilder::ForJSTypedArrayLength(),
76237621
Builtin::kTypedArrayPrototypeLength);
7624-
} else if (!v8_flags.turbo_rab_gsab) {
7625-
return inference.NoChange();
76267622
}
76277623

76287624
if (!inference.RelyOnMapsViaStability(dependencies())) {
Collapse file

‎deps/v8/src/compiler/js-native-context-specialization.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/compiler/js-native-context-specialization.cc
-4Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3199,8 +3199,6 @@ JSNativeContextSpecialization::BuildElementAccess(
31993199
// TODO(bmeurer): We currently specialize based on elements kind. We should
32003200
// also be able to properly support strings and other JSObjects here.
32013201
ElementsKind elements_kind = access_info.elements_kind();
3202-
DCHECK_IMPLIES(IsRabGsabTypedArrayElementsKind(elements_kind),
3203-
v8_flags.turbo_rab_gsab);
32043202
ZoneVector<MapRef> const& receiver_maps =
32053203
access_info.lookup_start_object_maps();
32063204

@@ -3586,8 +3584,6 @@ JSNativeContextSpecialization::
35863584
KeyedAccessMode const& keyed_mode) {
35873585
DCHECK(IsTypedArrayElementsKind(elements_kind) ||
35883586
IsRabGsabTypedArrayElementsKind(elements_kind));
3589-
DCHECK_IMPLIES(IsRabGsabTypedArrayElementsKind(elements_kind),
3590-
v8_flags.turbo_rab_gsab);
35913587
// AccessMode::kDefine is not handled here. Optimization should be skipped by
35923588
// caller.
35933589
DCHECK(keyed_mode.access_mode() != AccessMode::kDefine);
Collapse file

‎deps/v8/src/flags/flag-definitions.h‎

Copy file name to clipboardExpand all lines: deps/v8/src/flags/flag-definitions.h
-8Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -280,8 +280,6 @@ DEFINE_BOOL(js_shipping, true, "enable all shipped JavaScript features")
280280
V(js_regexp_modifiers, "RegExp modifiers") \
281281
V(js_regexp_duplicate_named_groups, "RegExp duplicate named groups")
282282

283-
DEFINE_WEAK_IMPLICATION(harmony_rab_gsab_transfer, harmony_rab_gsab)
284-
285283
#ifdef V8_INTL_SUPPORT
286284
#define HARMONY_STAGED(V) HARMONY_STAGED_BASE(V)
287285
#define JAVASCRIPT_STAGED_FEATURES(V) JAVASCRIPT_STAGED_FEATURES_BASE(V)
@@ -293,11 +291,8 @@ DEFINE_WEAK_IMPLICATION(harmony_rab_gsab_transfer, harmony_rab_gsab)
293291
// Features that are shipping (turned on by default, but internal flag remains).
294292
#define HARMONY_SHIPPING_BASE(V) \
295293
V(harmony_import_assertions, "harmony import assertions") \
296-
V(harmony_rab_gsab, \
297-
"harmony ResizableArrayBuffer / GrowableSharedArrayBuffer") \
298294
V(harmony_regexp_unicode_sets, "harmony RegExp Unicode Sets") \
299295
V(harmony_json_parse_with_source, "harmony json parse with source") \
300-
V(harmony_rab_gsab_transfer, "harmony ArrayBuffer.transfer") \
301296
V(harmony_array_grouping, "harmony array grouping") \
302297
V(harmony_array_from_async, "harmony Array.fromAsync") \
303298
V(harmony_iterator_helpers, "JavaScript iterator helpers") \
@@ -1278,9 +1273,6 @@ DEFINE_BOOL_READONLY(turbo_rewrite_far_jumps, false,
12781273
"rewrite far to near jumps (ia32,x64)")
12791274
#endif
12801275

1281-
DEFINE_BOOL(
1282-
turbo_rab_gsab, true,
1283-
"optimize ResizableArrayBuffer / GrowableSharedArrayBuffer in TurboFan")
12841276
DEFINE_BOOL(
12851277
stress_gc_during_compilation, false,
12861278
"simulate GC/compiler thread race related to https://crbug.com/v8/8520")
Collapse file

‎deps/v8/src/heap/factory.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/heap/factory.cc
+1-5Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3220,7 +3220,7 @@ Handle<JSArrayBuffer> Factory::NewJSArrayBuffer(
32203220
isolate()->native_context()->array_buffer_fun()->initial_map(),
32213221
isolate());
32223222
ResizableFlag resizable_by_js = ResizableFlag::kNotResizable;
3223-
if (v8_flags.harmony_rab_gsab && backing_store->is_resizable_by_js()) {
3223+
if (backing_store->is_resizable_by_js()) {
32243224
resizable_by_js = ResizableFlag::kResizable;
32253225
}
32263226
auto result =
@@ -3276,8 +3276,6 @@ MaybeHandle<JSArrayBuffer> Factory::NewJSArrayBufferAndBackingStore(
32763276

32773277
Handle<JSArrayBuffer> Factory::NewJSSharedArrayBuffer(
32783278
std::shared_ptr<BackingStore> backing_store) {
3279-
DCHECK_IMPLIES(backing_store->is_resizable_by_js(),
3280-
v8_flags.harmony_rab_gsab);
32813279
Handle<Map> map(
32823280
isolate()->native_context()->shared_array_buffer_fun()->initial_map(),
32833281
isolate());
@@ -3383,7 +3381,6 @@ Handle<JSTypedArray> Factory::NewJSTypedArray(
33833381
ElementsKind elements_kind;
33843382
JSTypedArray::ForFixedTypedArray(type, &element_size, &elements_kind);
33853383

3386-
CHECK_IMPLIES(is_length_tracking, v8_flags.harmony_rab_gsab);
33873384
const bool is_backed_by_rab =
33883385
buffer->is_resizable_by_js() && !buffer->is_shared();
33893386

@@ -3425,7 +3422,6 @@ Handle<JSTypedArray> Factory::NewJSTypedArray(
34253422
Handle<JSDataViewOrRabGsabDataView> Factory::NewJSDataViewOrRabGsabDataView(
34263423
DirectHandle<JSArrayBuffer> buffer, size_t byte_offset, size_t byte_length,
34273424
bool is_length_tracking) {
3428-
CHECK_IMPLIES(is_length_tracking, v8_flags.harmony_rab_gsab);
34293425
if (is_length_tracking) {
34303426
// Security: enforce the invariant that length-tracking DataViews have their
34313427
// byte_length set to 0.
Collapse file

‎deps/v8/src/init/bootstrapper.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/init/bootstrapper.cc
+32-41Lines changed: 32 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -4054,6 +4054,25 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
40544054
"arrayBufferConstructor_DoNotInitialize"),
40554055
Builtin::kArrayBufferConstructor_DoNotInitialize, 1, false);
40564056
native_context()->set_array_buffer_noinit_fun(*array_buffer_noinit_fun);
4057+
4058+
Handle<JSObject> array_buffer_prototype(
4059+
JSObject::cast(array_buffer_fun->instance_prototype()), isolate_);
4060+
SimpleInstallGetter(isolate_, array_buffer_prototype,
4061+
factory->max_byte_length_string(),
4062+
Builtin::kArrayBufferPrototypeGetMaxByteLength, false);
4063+
SimpleInstallGetter(isolate_, array_buffer_prototype,
4064+
factory->resizable_string(),
4065+
Builtin::kArrayBufferPrototypeGetResizable, false);
4066+
SimpleInstallFunction(isolate_, array_buffer_prototype, "resize",
4067+
Builtin::kArrayBufferPrototypeResize, 1, true);
4068+
SimpleInstallFunction(isolate_, array_buffer_prototype, "transfer",
4069+
Builtin::kArrayBufferPrototypeTransfer, 0, false);
4070+
SimpleInstallFunction(
4071+
isolate_, array_buffer_prototype, "transferToFixedLength",
4072+
Builtin::kArrayBufferPrototypeTransferToFixedLength, 0, false);
4073+
SimpleInstallGetter(isolate_, array_buffer_prototype,
4074+
factory->detached_string(),
4075+
Builtin::kArrayBufferPrototypeGetDetached, false);
40574076
}
40584077

40594078
{ // -- S h a r e d A r r a y B u f f e r
@@ -4063,6 +4082,19 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
40634082
InstallWithIntrinsicDefaultProto(isolate_, shared_array_buffer_fun,
40644083
Context::SHARED_ARRAY_BUFFER_FUN_INDEX);
40654084
InstallSpeciesGetter(isolate_, shared_array_buffer_fun);
4085+
4086+
Handle<JSObject> shared_array_buffer_prototype(
4087+
JSObject::cast(shared_array_buffer_fun->instance_prototype()),
4088+
isolate_);
4089+
SimpleInstallGetter(isolate_, shared_array_buffer_prototype,
4090+
factory->max_byte_length_string(),
4091+
Builtin::kSharedArrayBufferPrototypeGetMaxByteLength,
4092+
false);
4093+
SimpleInstallGetter(isolate_, shared_array_buffer_prototype,
4094+
factory->growable_string(),
4095+
Builtin::kSharedArrayBufferPrototypeGetGrowable, false);
4096+
SimpleInstallFunction(isolate_, shared_array_buffer_prototype, "grow",
4097+
Builtin::kSharedArrayBufferPrototypeGrow, 1, true);
40664098
}
40674099

40684100
{ // -- A t o m i c s
@@ -5300,7 +5332,6 @@ void Genesis::InitializeConsole(Handle<JSObject> extras_binding) {
53005332

53015333
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_import_assertions)
53025334
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_import_attributes)
5303-
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_rab_gsab_transfer)
53045335
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(js_regexp_modifiers)
53055336
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(js_regexp_duplicate_named_groups)
53065337

@@ -5768,46 +5799,6 @@ void Genesis::InitializeGlobal_regexp_linear_flag() {
57685799
native_context()->set_regexp_prototype_map(regexp_prototype->map());
57695800
}
57705801

5771-
void Genesis::InitializeGlobal_harmony_rab_gsab() {
5772-
if (!v8_flags.harmony_rab_gsab) return;
5773-
Handle<JSObject> array_buffer_prototype(
5774-
JSObject::cast(
5775-
native_context()->array_buffer_fun()->instance_prototype()),
5776-
isolate());
5777-
SimpleInstallGetter(isolate(), array_buffer_prototype,
5778-
factory()->max_byte_length_string(),
5779-
Builtin::kArrayBufferPrototypeGetMaxByteLength, false);
5780-
SimpleInstallGetter(isolate(), array_buffer_prototype,
5781-
factory()->resizable_string(),
5782-
Builtin::kArrayBufferPrototypeGetResizable, false);
5783-
SimpleInstallFunction(isolate(), array_buffer_prototype, "resize",
5784-
Builtin::kArrayBufferPrototypeResize, 1, true);
5785-
if (v8_flags.harmony_rab_gsab_transfer) {
5786-
SimpleInstallFunction(isolate(), array_buffer_prototype, "transfer",
5787-
Builtin::kArrayBufferPrototypeTransfer, 0, false);
5788-
SimpleInstallFunction(
5789-
isolate(), array_buffer_prototype, "transferToFixedLength",
5790-
Builtin::kArrayBufferPrototypeTransferToFixedLength, 0, false);
5791-
SimpleInstallGetter(isolate(), array_buffer_prototype,
5792-
factory()->detached_string(),
5793-
Builtin::kArrayBufferPrototypeGetDetached, false);
5794-
}
5795-
5796-
Handle<JSObject> shared_array_buffer_prototype(
5797-
JSObject::cast(
5798-
native_context()->shared_array_buffer_fun()->instance_prototype()),
5799-
isolate());
5800-
SimpleInstallGetter(isolate(), shared_array_buffer_prototype,
5801-
factory()->max_byte_length_string(),
5802-
Builtin::kSharedArrayBufferPrototypeGetMaxByteLength,
5803-
false);
5804-
SimpleInstallGetter(isolate(), shared_array_buffer_prototype,
5805-
factory()->growable_string(),
5806-
Builtin::kSharedArrayBufferPrototypeGetGrowable, false);
5807-
SimpleInstallFunction(isolate(), shared_array_buffer_prototype, "grow",
5808-
Builtin::kSharedArrayBufferPrototypeGrow, 1, true);
5809-
}
5810-
58115802
void Genesis::InitializeGlobal_harmony_temporal() {
58125803
if (!v8_flags.harmony_temporal) return;
58135804

Collapse file

‎deps/v8/src/objects/js-array-buffer.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/objects/js-array-buffer.cc
-2Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,6 @@ size_t JSArrayBuffer::GsabByteLength(Isolate* isolate,
177177
Address raw_array_buffer) {
178178
// TODO(v8:11111): Cache the last seen length in JSArrayBuffer and use it
179179
// in bounds checks to minimize the need for calling this function.
180-
DCHECK(v8_flags.harmony_rab_gsab);
181180
DisallowGarbageCollection no_gc;
182181
DisallowJavascriptExecution no_js(isolate);
183182
Tagged<JSArrayBuffer> buffer =
@@ -405,7 +404,6 @@ size_t JSTypedArray::LengthTrackingGsabBackedTypedArrayLength(
405404
Isolate* isolate, Address raw_array) {
406405
// TODO(v8:11111): Cache the last seen length in JSArrayBuffer and use it
407406
// in bounds checks to minimize the need for calling this function.
408-
DCHECK(v8_flags.harmony_rab_gsab);
409407
DisallowGarbageCollection no_gc;
410408
DisallowJavascriptExecution no_js(isolate);
411409
Tagged<JSTypedArray> array = JSTypedArray::cast(Tagged<Object>(raw_array));
Collapse file

‎deps/v8/src/objects/value-serializer.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/objects/value-serializer.cc
-19Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1009,7 +1009,6 @@ Maybe<bool> ValueSerializer::WriteJSArrayBufferView(
10091009
ArrayBufferViewTag tag = ArrayBufferViewTag::kInt8Array;
10101010
if (IsJSTypedArray(view)) {
10111011
if (JSTypedArray::cast(view)->IsOutOfBounds()) {
1012-
DCHECK(v8_flags.harmony_rab_gsab);
10131012
return ThrowDataCloneError(MessageTemplate::kDataCloneError,
10141013
handle(view, isolate_));
10151014
}
@@ -1025,7 +1024,6 @@ Maybe<bool> ValueSerializer::WriteJSArrayBufferView(
10251024
DCHECK(IsJSDataViewOrRabGsabDataView(view));
10261025
if (IsJSRabGsabDataView(view) &&
10271026
JSRabGsabDataView::cast(view)->IsOutOfBounds()) {
1028-
DCHECK(v8_flags.harmony_rab_gsab);
10291027
return ThrowDataCloneError(MessageTemplate::kDataCloneError,
10301028
handle(view, isolate_));
10311029
}
@@ -2105,13 +2103,6 @@ MaybeHandle<JSArrayBuffer> ValueDeserializer::ReadJSArrayBuffer(
21052103
if (byte_length > max_byte_length) {
21062104
return MaybeHandle<JSArrayBuffer>();
21072105
}
2108-
if (!v8_flags.harmony_rab_gsab) {
2109-
// Disable resizability. This ensures that no resizable buffers are
2110-
// created in a version which has the harmony_rab_gsab turned off, even if
2111-
// such a version is reading data containing resizable buffers from disk.
2112-
is_resizable = false;
2113-
max_byte_length = byte_length;
2114-
}
21152106
}
21162107
if (byte_length > static_cast<size_t>(end_ - position_)) {
21172108
return MaybeHandle<JSArrayBuffer>();
@@ -2233,16 +2224,6 @@ bool ValueDeserializer::ValidateJSArrayBufferViewFlags(
22332224
// TODO(marja): When the version number is bumped the next time, check that
22342225
// serialized_flags doesn't contain spurious 1-bits.
22352226

2236-
if (!v8_flags.harmony_rab_gsab) {
2237-
// Disable resizability. This ensures that no resizable buffers are
2238-
// created in a version which has the harmony_rab_gsab turned off, even if
2239-
// such a version is reading data containing resizable buffers from disk.
2240-
is_length_tracking = false;
2241-
is_backed_by_rab = false;
2242-
// The resizability of the buffer was already disabled.
2243-
CHECK(!buffer->is_resizable_by_js());
2244-
}
2245-
22462227
if (is_backed_by_rab || is_length_tracking) {
22472228
if (!buffer->is_resizable_by_js()) {
22482229
return false;

0 commit comments

Comments
0 (0)
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.