GeezerVison is showing github.com — crypto: hard-code tlsSocket.getCipher().version · nodejs/node@8a8ac8c
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: doc/api/tls.md +3-3Lines changed: 3 additions & 3 deletions - Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|
@@ -558,12 +558,12 @@ Always returns `true`. This may be used to distinguish TLS sockets from regular |
558 | 558 | added: v0.11.4 |
559 | 559 | --> |
560 | 560 |
|
561 | | -Returns an object representing the cipher name and the SSL/TLS protocol version |
562 | | -that first defined the cipher. |
| 561 | +Returns an object representing the cipher name. The `version` key is a legacy |
| 562 | +field which always contains the value `'TLSv1/SSLv3'`. |
563 | 563 |
|
564 | 564 | For example: `{ name: 'AES256-SHA', version: 'TLSv1/SSLv3' }` |
565 | 565 |
|
566 | | -See `SSL_CIPHER_get_name()` and `SSL_CIPHER_get_version()` in |
| 566 | +See `SSL_CIPHER_get_name()` in |
567 | 567 | https://www.openssl.org/docs/man1.0.2/ssl/SSL_CIPHER_get_name.html for more |
568 | 568 | information. |
569 | 569 |
|
|
Collapse file
Copy file name to clipboardExpand all lines: src/node_crypto.cc +1-2Lines changed: 1 addition & 2 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -2265,9 +2265,8 @@ void SSLWrap<Base>::GetCurrentCipher(const FunctionCallbackInfo<Value>& args) { |
2265 | 2265 | Local<Object> info = Object::New(env->isolate()); |
2266 | 2266 | const char* cipher_name = SSL_CIPHER_get_name(c); |
2267 | 2267 | info->Set(env->name_string(), OneByteString(args.GetIsolate(), cipher_name)); |
2268 | | - const char* cipher_version = SSL_CIPHER_get_version(c); |
2269 | 2268 | info->Set(env->version_string(), |
2270 | | - OneByteString(args.GetIsolate(), cipher_version)); |
| 2269 | + OneByteString(args.GetIsolate(), "TLSv1/SSLv3")); |
2271 | 2270 | args.GetReturnValue().Set(info); |
2272 | 2271 | } |
2273 | 2272 |
|
|