GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Revert "inspector: move process.binding to internalBinding" · nodejs/node@8cc9757

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

lib
- inspector.js
- internal
  - bootstrap
    - loaders.js
  - inspector_async_hook.js
  - modules
    - cjs
      - helpers.js
      - loader.js
    - esm
      - module_job.js
  - process
    - coverage.js
src
- inspector_js_api.cc
- node.cc
test
- parallel
  - test-process-binding-internalbinding-whitelist.js
- sequential
  - test-async-wrap-getasyncid.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎lib/inspector.js‎`

Copy file name to clipboardExpand all lines: lib/inspector.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ const {`
`11`	`11`	`} = require('internal/errors').codes;`
`12`	`12`	`const { validateString } = require('internal/validators');`
`13`	`13`	`const util = require('util');`
`14`		`-const { Connection, open, url } = internalBinding('inspector');`
	`14`	`+const { Connection, open, url } = process.binding('inspector');`
`15`	`15`
`16`	`16`	`if (!Connection)`
`17`	`17`	`throw new ERR_INSPECTOR_NOT_AVAILABLE();`

Collapse file

`‎lib/internal/bootstrap/loaders.js‎`

Copy file name to clipboardExpand all lines: lib/internal/bootstrap/loaders.js

-1Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,6 @@`
`85`	`85`	`'fs_event_wrap',`
`86`	`86`	`'http_parser',`
`87`	`87`	`'icu',`
`88`		`- 'inspector',`
`89`	`88`	`'js_stream',`
`90`	`89`	`'natives',`
`91`	`90`	`'os',`

Collapse file

`‎lib/internal/inspector_async_hook.js‎`

Copy file name to clipboardExpand all lines: lib/internal/inspector_async_hook.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`'use strict';`
`2`	`2`
`3`		`-const inspector = internalBinding('inspector');`
	`3`	`+const inspector = process.binding('inspector');`
`4`	`4`
`5`	`5`	`if (!inspector \|\| !inspector.asyncTaskScheduled) {`
`6`	`6`	`exports.setup = function() {};`

Collapse file

`‎lib/internal/modules/cjs/helpers.js‎`

Copy file name to clipboardExpand all lines: lib/internal/modules/cjs/helpers.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,7 @@ if (getOptionValue('--experimental-worker')) {`
`108`	`108`	`builtinLibs.sort();`
`109`	`109`	`}`
`110`	`110`
`111`		`-if (typeof internalBinding('inspector').open === 'function') {`
	`111`	`+if (typeof process.binding('inspector').open === 'function') {`
`112`	`112`	`builtinLibs.push('inspector');`
`113`	`113`	`builtinLibs.sort();`
`114`	`114`	`}`

Collapse file

`‎lib/internal/modules/cjs/loader.js‎`

Copy file name to clipboardExpand all lines: lib/internal/modules/cjs/loader.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -706,7 +706,7 @@ Module.prototype._compile = function(content, filename) {`
`706`	`706`	`// Set breakpoint on module start`
`707`	`707`	`if (filename === resolvedArgv) {`
`708`	`708`	`delete process._breakFirstLine;`
`709`		`- inspectorWrapper = internalBinding('inspector').callAndPauseOnStart;`
	`709`	`+ inspectorWrapper = process.binding('inspector').callAndPauseOnStart;`
`710`	`710`	`}`
`711`	`711`	`}`
`712`	`712`	`var dirname = path.dirname(filename);`

Collapse file

`‎lib/internal/modules/esm/module_job.js‎`

Copy file name to clipboardExpand all lines: lib/internal/modules/esm/module_job.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ class ModuleJob {`
`73`	`73`	`try {`
`74`	`74`	`if (this.isMain && process._breakFirstLine) {`
`75`	`75`	`delete process._breakFirstLine;`
`76`		`- const initWrapper = internalBinding('inspector').callAndPauseOnStart;`
	`76`	`+ const initWrapper = process.binding('inspector').callAndPauseOnStart;`
`77`	`77`	`initWrapper(this.module.instantiate, this.module);`
`78`	`78`	`} else {`
`79`	`79`	`this.module.instantiate();`

Collapse file

`‎lib/internal/process/coverage.js‎`

Copy file name to clipboardExpand all lines: lib/internal/process/coverage.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ function disableAllAsyncHooks() {`
`51`	`51`	`exports.writeCoverage = writeCoverage;`
`52`	`52`
`53`	`53`	`function setup() {`
`54`		`- const { Connection } = internalBinding('inspector');`
	`54`	`+ const { Connection } = process.binding('inspector');`
`55`	`55`	`if (!Connection) {`
`56`	`56`	`console.warn('inspector not enabled');`
`57`	`57`	`return;`

Collapse file

`‎src/inspector_js_api.cc‎`

Copy file name to clipboardExpand all lines: src/inspector_js_api.cc

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -315,5 +315,5 @@ void Initialize(Local<Object> target, Local<Value> unused,`
`315`	`315`	`} // namespace inspector`
`316`	`316`	`} // namespace node`
`317`	`317`
`318`		`-NODE_MODULE_CONTEXT_AWARE_INTERNAL(inspector,`
	`318`	`+NODE_BUILTIN_MODULE_CONTEXT_AWARE(inspector,`
`319`	`319`	`node::inspector::Initialize);`

Collapse file

`‎src/node.cc‎`

Copy file name to clipboardExpand all lines: src/node.cc

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2238,5 +2238,5 @@ int Start(int argc, char** argv) {`
`2238`	`2238`	`#if !HAVE_INSPECTOR`
`2239`	`2239`	`void Initialize() {}`
`2240`	`2240`
`2241`		`-NODE_MODULE_CONTEXT_AWARE_INTERNAL(inspector, Initialize)`
	`2241`	`+NODE_BUILTIN_MODULE_CONTEXT_AWARE(inspector, Initialize)`
`2242`	`2242`	`#endif // !HAVE_INSPECTOR`

Collapse file

`‎test/parallel/test-process-binding-internalbinding-whitelist.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-process-binding-internalbinding-whitelist.js

-1Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -16,5 +16,4 @@ assert(process.binding('url'));`
`16`	`16`	`assert(process.binding('spawn_sync'));`
`17`	`17`	`assert(process.binding('js_stream'));`
`18`	`18`	`assert(process.binding('buffer'));`
`19`		`-assert(process.binding('inspector'));`
`20`	`19`	`assert(process.binding('os'));`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.