GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — http: lazy allocate cookies array · nodejs/node@95644a4

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

lib
- _http_outgoing.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎lib/_http_outgoing.js‎`

Copy file name to clipboardExpand all lines: lib/_http_outgoing.js

+4-2Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -673,20 +673,22 @@ OutgoingMessage.prototype.setHeaders = function setHeaders(headers) {`
`673`	`673`	`// We also cannot safely split by comma.`
`674`	`674`	`// To avoid setHeader overwriting the previous value we push`
`675`	`675`	`// set-cookie values in array and set them all at once.`
`676`		`- const cookies = [];`
	`676`	`+ let cookies = null;`
`677`	`677`
`678`	`678`	`for (const { 0: key, 1: value } of headers) {`
`679`	`679`	`if (key === 'set-cookie') {`
`680`	`680`	`if (ArrayIsArray(value)) {`
	`681`	`+ cookies ??= [];`
`681`	`682`	`cookies.push(...value);`
`682`	`683`	`} else {`
	`684`	`+ cookies ??= [];`
`683`	`685`	`cookies.push(value);`
`684`	`686`	`}`
`685`	`687`	`continue;`
`686`	`688`	`}`
`687`	`689`	`this.setHeader(key, value);`
`688`	`690`	`}`
`689`		`- if (cookies.length) {`
	`691`	`+ if (cookies != null) {`
`690`	`692`	`this.setHeader('set-cookie', cookies);`
`691`	`693`	`}`
`692`	`694`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.