GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — events: add stop propagation flag to `Event.stopImmediatePropagation` · nodejs/node@96566fc

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

lib/internal
- event_target.js
test/parallel
- test-eventtarget.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎lib/internal/event_target.js‎`

Copy file name to clipboardExpand all lines: lib/internal/event_target.js

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -168,6 +168,10 @@ class Event {`
`168`	`168`	`stopImmediatePropagation() {`
`169`	`169`	`if (!isEvent(this))`
`170`	`170`	`throw new ERR_INVALID_THIS('Event');`
	`171`	`+ // Spec mention "stopImmediatePropagation should set both "stop propagation"`
	`172`	`+ // and "stop immediate propagation" flags"`
	`173`	`+ // cf: from https://dom.spec.whatwg.org/#dom-event-stopimmediatepropagation`
	`174`	`+ this.stopPropagation();`
`171`	`175`	`this[kStop] = true;`
`172`	`176`	`}`
`173`	`177`

Collapse file

`‎test/parallel/test-eventtarget.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-eventtarget.js

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -345,7 +345,9 @@ let asyncTest = Promise.resolve();`
`345`	`345`	`{`
`346`	`346`	`const target = new EventTarget();`
`347`	`347`	`const event = new Event('foo');`
	`348`	`+ strictEqual(event.cancelBubble, false);`
`348`	`349`	`event.stopImmediatePropagation();`
	`350`	`+ strictEqual(event.cancelBubble, true);`
`349`	`351`	`target.addEventListener('foo', common.mustNotCall());`
`350`	`352`	`target.dispatchEvent(event);`
`351`	`353`	`}`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.