GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — src: fix double free reported by coverity · nodejs/node@9b7f79a

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

src
- node_internals.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎src/node_internals.h‎`

Copy file name to clipboardExpand all lines: src/node_internals.h

+5-8Lines changed: 5 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -192,16 +192,13 @@ static v8::MaybeLocal<v8::Object> New(Environment* env,`
`192`	`192`	`char* src = reinterpret_cast<char*>(buf->out());`
`193`	`193`	`const size_t len_in_bytes = buf->length() * sizeof(buf->out()[0]);`
`194`	`194`
`195`		`- if (buf->IsAllocated())`
	`195`	`+ if (buf->IsAllocated()) {`
`196`	`196`	`ret = New(env, src, len_in_bytes);`
`197`		`- else if (!buf->IsInvalidated())`
`198`		`- ret = Copy(env, src, len_in_bytes);`
`199`		`-`
`200`		`- if (ret.IsEmpty())`
`201`		`- return ret;`
`202`		`-`
`203`		`- if (buf->IsAllocated())`
	`197`	`+ // new always takes ownership of src`
`204`	`198`	`buf->Release();`
	`199`	`+ } else if (!buf->IsInvalidated()) {`
	`200`	`+ ret = Copy(env, src, len_in_bytes);`
	`201`	`+ }`
`205`	`202`
`206`	`203`	`return ret;`
`207`	`204`	`}`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.