GeezerVison is showing github.com — test: improve flakiness detection on stack corruption tests · nodejs/node@9ccdf4f
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: test/async-hooks/test-emit-after-on-destroyed.js +5-2Lines changed: 5 additions & 2 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -53,9 +53,12 @@ if (process.argv[2] === 'child') { |
53 | 53 | child.stdout.on('data', (d) => { outData = Buffer.concat([ outData, d ]); }); |
54 | 54 |
|
55 | 55 | child.on('close', common.mustCall((code, signal) => { |
56 | | - if (signal) { |
57 | | - console.log(`Child closed with signal: ${signal}`); |
| 56 | + if ((common.isAIX || |
| 57 | + (common.isLinux && process.arch === 'x64')) && |
| 58 | + signal === 'SIGABRT') { |
| 59 | + // XXX: The child process could be aborted due to unknown reasons. Work around it. |
58 | 60 | } else { |
| 61 | + assert.strictEqual(signal, null); |
59 | 62 | assert.strictEqual(code, 1); |
60 | 63 | } |
61 | 64 | assert.match(outData.toString(), heartbeatMsg, |
|
Collapse file
Copy file name to clipboardExpand all lines: test/async-hooks/test-improper-unwind.js +5-2Lines changed: 5 additions & 2 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -56,9 +56,12 @@ if (process.argv[2] === 'child') { |
56 | 56 | child.stdout.on('data', (d) => { outData = Buffer.concat([ outData, d ]); }); |
57 | 57 |
|
58 | 58 | child.on('close', common.mustCall((code, signal) => { |
59 | | - if (signal) { |
60 | | - console.log(`Child closed with signal: ${signal}`); |
| 59 | + if ((common.isAIX || |
| 60 | + (common.isLinux && process.arch === 'x64')) && |
| 61 | + signal === 'SIGABRT') { |
| 62 | + // XXX: The child process could be aborted due to unknown reasons. Work around it. |
61 | 63 | } else { |
| 64 | + assert.strictEqual(signal, null); |
62 | 65 | assert.strictEqual(code, 1); |
63 | 66 | } |
64 | 67 | assert.match(outData.toString(), heartbeatMsg, |
|