GeezerVison is showing github.com — build,lib,test: change whitelist to allowlist · nodejs/node@9ccf7db
File treeExpand file treeCollapse file tree Open diff view settings Expand file treeCollapse file tree Open diff view settings Collapse file Copy file name to clipboardExpand all lines: configure.py +1-1Lines changed: 1 addition & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
@@ -857,7 +857,7 @@ def get_gas_version(cc): | 857 | 857 |
| 858 | 858 | # Note: Apple clang self-reports as clang 4.2.0 and gcc 4.2.1. It passes | 859 | 859 | # the version check more by accident than anything else but a more rigorous | 860 | | -# check involves checking the build number against a whitelist. I'm not | | 860 | +# check involves checking the build number against an allowlist. I'm not | 861 | 861 | # quite prepared to go that far yet. | 862 | 862 | def check_compiler(o): | 863 | 863 | if sys.platform == 'win32': | |
Collapse file Copy file name to clipboardExpand all lines: lib/internal/bootstrap/loaders.js +4-4Lines changed: 4 additions & 4 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -69,11 +69,11 @@ ObjectDefineProperty(process, 'moduleLoadList', { | 69 | 69 | }); | 70 | 70 |
| 71 | 71 |
| 72 | | -// internalBindingWhitelist contains the name of internalBinding modules | 73 | | -// that are whitelisted for access via process.binding()... This is used | | 72 | +// internalBindingAllowlist contains the name of internalBinding modules | | 73 | +// that are allowed for access via process.binding()... This is used | 74 | 74 | // to provide a transition path for modules that are being moved over to | 75 | 75 | // internalBinding. | 76 | | -const internalBindingWhitelist = new SafeSet([ | | 76 | +const internalBindingAllowlist = new SafeSet([ | 77 | 77 | 'async_wrap', | 78 | 78 | 'buffer', | 79 | 79 | 'cares_wrap', | @@ -113,7 +113,7 @@ const internalBindingWhitelist = new SafeSet([ | 113 | 113 | module = String(module); | 114 | 114 | // Deprecated specific process.binding() modules, but not all, allow | 115 | 115 | // selective fallback to internalBinding for the deprecated ones. | 116 | | - if (internalBindingWhitelist.has(module)) { | | 116 | + if (internalBindingAllowlist.has(module)) { | 117 | 117 | return internalBinding(module); | 118 | 118 | } | 119 | 119 | // eslint-disable-next-line no-restricted-syntax | |
Collapse file Copy file name to clipboardExpand all lines: test/common/README.md +4-4Lines changed: 4 additions & 4 deletions - Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|
@@ -39,12 +39,12 @@ The `benchmark` module is used by tests to run benchmarks. | 39 | 39 | The `common` module is used by tests for consistency across repeated | 40 | 40 | tasks. | 41 | 41 |
| 42 | | -### `allowGlobals(...whitelist)` | | 42 | +### `allowGlobals(...allowlist)` | 43 | 43 |
| 44 | | -* `whitelist` [<Array>][] Array of Globals | | 44 | +* `allowlist` [<Array>][] Array of Globals | 45 | 45 | * return [<Array>][] | 46 | 46 |
| 47 | | -Takes `whitelist` and concats that with predefined `knownGlobals`. | | 47 | +Takes `allowlist` and concats that with predefined `knownGlobals`. | 48 | 48 |
| 49 | 49 | ### `canCreateSymLink()` | 50 | 50 |
| @@ -600,7 +600,7 @@ If set, crypto tests are skipped. | 600 | 600 | ### `NODE_TEST_KNOWN_GLOBALS` | 601 | 601 |
| 602 | 602 | A comma-separated list of variables names that are appended to the global | 603 | | -variable whitelist. Alternatively, if `NODE_TEST_KNOWN_GLOBALS` is set to `'0'`, | | 603 | +variable allowlist. Alternatively, if `NODE_TEST_KNOWN_GLOBALS` is set to `'0'`, | 604 | 604 | global leak detection is disabled. | 605 | 605 |
| 606 | 606 | ## Fixtures Module | |
Collapse file Copy file name to clipboardExpand all lines: test/common/index.js +2-2Lines changed: 2 additions & 2 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -275,8 +275,8 @@ if (global.gc) { | 275 | 275 | knownGlobals.push(global.gc); | 276 | 276 | } | 277 | 277 |
| 278 | | -function allowGlobals(...whitelist) { | 279 | | - knownGlobals = knownGlobals.concat(whitelist); | | 278 | +function allowGlobals(...allowlist) { | | 279 | + knownGlobals = knownGlobals.concat(allowlist); | 280 | 280 | } | 281 | 281 |
| 282 | 282 | if (process.env.NODE_TEST_KNOWN_GLOBALS !== '0') { | |
Collapse file Copy file name to clipboardExpand all lines: test/parallel/test-process-binding-internalbinding-allowlist.js +1-1Lines changed: 1 addition & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
| 4 | 4 | const common = require('../common'); | 5 | 5 | const assert = require('assert'); | 6 | 6 |
| 7 | | -// Assert that whitelisted internalBinding modules are accessible via | | 7 | +// Assert that allowed internalBinding modules are accessible via | 8 | 8 | // process.binding(). | 9 | 9 | assert(process.binding('async_wrap')); | 10 | 10 | assert(process.binding('buffer')); | |
|