GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — assert: fix `deepStrictEqual` on errors when `cause` is not undefined · nodejs/node@9dbb255

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • lib/internal/assert
    • assertion_error.js
  • test/parallel
    • test-assert-deep-with-error.js
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎lib/internal/assert/assertion_error.js‎

Copy file name to clipboardExpand all lines: lib/internal/assert/assertion_error.js
+11Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ const {
1515
StringPrototypeSplit,
1616
} = primordials;
1717

18+
const { isError } = require('internal/util');
19+
1820
const { inspect } = require('internal/util/inspect');
1921
const colors = require('internal/util/colors');
2022
const { validateObject } = require('internal/validators');
@@ -47,6 +49,15 @@ function copyError(source) {
4749
__proto__: null,
4850
value: source.message,
4951
});
52+
if (source.cause !== undefined) {
53+
let cause = source.cause;
54+
55+
if (isError(cause)) {
56+
cause = copyError(cause);
57+
}
58+
59+
ObjectDefineProperty(target, 'cause', { __proto__: null, value: cause });
60+
}
5061
return target;
5162
}
5263

Collapse file

‎test/parallel/test-assert-deep-with-error.js‎

Copy file name to clipboard
+39Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
'use strict';
2+
require('../common');
3+
const assert = require('assert');
4+
const { test } = require('node:test');
5+
6+
const defaultStartMessage = 'Expected values to be strictly deep-equal:\n' +
7+
'+ actual - expected\n' +
8+
'\n';
9+
10+
test('Handle error causes', () => {
11+
assert.throws(() => {
12+
assert.deepStrictEqual(new Error('a', { cause: new Error('x') }), new Error('a', { cause: new Error('y') }));
13+
}, { message: defaultStartMessage + ' [Error: a] {\n' +
14+
'+ [cause]: [Error: x]\n' +
15+
'- [cause]: [Error: y]\n' +
16+
' }\n' });
17+
18+
assert.throws(() => {
19+
assert.deepStrictEqual(new Error('a'), new Error('a', { cause: new Error('y') }));
20+
}, { message: defaultStartMessage + '+ [Error: a]\n' +
21+
'- [Error: a] {\n' +
22+
'- [cause]: [Error: y]\n' +
23+
'- }\n' });
24+
25+
assert.throws(() => {
26+
assert.deepStrictEqual(new Error('a'), new Error('a', { cause: { prop: 'value' } }));
27+
}, { message: defaultStartMessage + '+ [Error: a]\n' +
28+
'- [Error: a] {\n' +
29+
'- [cause]: {\n' +
30+
'- prop: \'value\'\n' +
31+
'- }\n' +
32+
'- }\n' });
33+
34+
assert.notDeepStrictEqual(new Error('a', { cause: new Error('x') }), new Error('a', { cause: new Error('y') }));
35+
assert.notDeepStrictEqual(
36+
new Error('a', { cause: { prop: 'value' } }),
37+
new Error('a', { cause: { prop: 'a different value' } })
38+
);
39+
});

0 commit comments

Comments
0 (0)
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.