GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — test: add missing await in fs-rm/fs-rmdir tests · nodejs/node@9e7cfbb

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

test/parallel
- test-fs-rm.js
- test-fs-rmdir-recursive.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎test/parallel/test-fs-rm.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-fs-rm.js

+5-5Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -184,19 +184,19 @@ function removeAsync(dir) {`
`184`	`184`	`makeNonEmptyDirectory(4, 10, 2, dir, true);`
`185`	`185`
`186`	`186`	`// Removal should fail without the recursive option set to true.`
`187`		`- assert.rejects(fs.promises.rm(dir), { syscall: 'rm' });`
`188`		`- assert.rejects(fs.promises.rm(dir, { recursive: false }), {`
	`187`	`+ await assert.rejects(fs.promises.rm(dir), { syscall: 'rm' });`
	`188`	`+ await assert.rejects(fs.promises.rm(dir, { recursive: false }), {`
`189`	`189`	`syscall: 'rm'`
`190`	`190`	`});`
`191`	`191`
`192`	`192`	`// Recursive removal should succeed.`
`193`	`193`	`await fs.promises.rm(dir, { recursive: true });`
`194`	`194`
`195`	`195`	`// Attempted removal should fail now because the directory is gone.`
`196`		`- assert.rejects(fs.promises.rm(dir), { syscall: 'stat' });`
	`196`	`+ await assert.rejects(fs.promises.rm(dir), { syscall: 'stat' });`
`197`	`197`
`198`	`198`	`// Should fail if target does not exist`
`199`		`- assert.rejects(fs.promises.rm(`
	`199`	`+ await assert.rejects(fs.promises.rm(`
`200`	`200`	`path.join(tmpdir.path, 'noexist.txt'),`
`201`	`201`	`{ recursive: true }`
`202`	`202`	`), {`
`@@ -206,7 +206,7 @@ function removeAsync(dir) {`
`206`	`206`	`});`
`207`	`207`
`208`	`208`	`// Should not fail if target does not exist and force option is true`
`209`		`- fs.promises.rm(path.join(tmpdir.path, 'noexist.txt'), { force: true });`
	`209`	`+ await fs.promises.rm(path.join(tmpdir.path, 'noexist.txt'), { force: true });`
`210`	`210`
`211`	`211`	`// Should delete file`
`212`	`212`	`const filePath = path.join(tmpdir.path, 'rm-promises-file.txt');`

Collapse file

`‎test/parallel/test-fs-rmdir-recursive.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-fs-rmdir-recursive.js

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -141,8 +141,8 @@ function removeAsync(dir) {`
`141`	`141`	`makeNonEmptyDirectory(4, 10, 2, dir, true);`
`142`	`142`
`143`	`143`	`// Removal should fail without the recursive option set to true.`
`144`		`- assert.rejects(fs.promises.rmdir(dir), { syscall: 'rmdir' });`
`145`		`- assert.rejects(fs.promises.rmdir(dir, { recursive: false }), {`
	`144`	`+ await assert.rejects(fs.promises.rmdir(dir), { syscall: 'rmdir' });`
	`145`	`+ await assert.rejects(fs.promises.rmdir(dir, { recursive: false }), {`
`146`	`146`	`syscall: 'rmdir'`
`147`	`147`	`});`
`148`	`148`
`@@ -154,7 +154,7 @@ function removeAsync(dir) {`
`154`	`154`	`{ code: 'ENOENT' });`
`155`	`155`
`156`	`156`	`// Attempted removal should fail now because the directory is gone.`
`157`		`- assert.rejects(fs.promises.rmdir(dir), { syscall: 'rmdir' });`
	`157`	`+ await assert.rejects(fs.promises.rmdir(dir), { syscall: 'rmdir' });`
`158`	`158`	`})().then(common.mustCall());`
`159`	`159`
`160`	`160`	`// Test input validation.`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.