GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — test: remove deadlock workaround · nodejs/node@a0077c9

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

test/parallel

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎test/parallel/test-file-write-stream4.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-file-write-stream4.js

+1-6Lines changed: 1 addition & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-// Flags: --expose-gc`
`2`	`1`	`'use strict';`
`3`	`2`
`4`	`3`	// Test that 'close' emits once and not twice when `emitClose: true` is set.
`@@ -18,8 +17,4 @@ const fileWriteStream = fs.createWriteStream(filepath, {`
`18`	`17`	`});`
`19`	`18`
`20`	`19`	`fileReadStream.pipe(fileWriteStream);`
`21`		`-fileWriteStream.on('close', common.mustCall(() => {`
`22`		`- // TODO(lpinca): Remove the forced GC when`
`23`		`- // https://github.com/nodejs/node/issues/54918 is fixed.`
`24`		`- globalThis.gc({ type: 'major' });`
`25`		`-}));`
	`20`	`+fileWriteStream.on('close', common.mustCall());`

Collapse file

`‎test/parallel/test-net-write-fully-async-buffer.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-net-write-fully-async-buffer.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ const server = net.createServer(common.mustCall(function(conn) {`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`while (conn.write(Buffer.from(data)));`
`26`		`- globalThis.gc({ type: 'major' });`
	`26`	`+ globalThis.gc({ type: 'minor' });`
`27`	`27`	`// The buffer allocated above should still be alive.`
`28`	`28`	`}`
`29`	`29`

Collapse file

`‎test/parallel/test-net-write-fully-async-hex-string.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-net-write-fully-async-hex-string.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ const server = net.createServer(common.mustCall(function(conn) {`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`while (conn.write(data, 'hex'));`
`24`		`- globalThis.gc({ type: 'major' });`
	`24`	`+ globalThis.gc({ type: 'minor' });`
`25`	`25`	`// The buffer allocated inside the .write() call should still be alive.`
`26`	`26`	`}`
`27`	`27`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.