GeezerVison is showing github.com — doc: update collaborator guide to reflect TSC changes · nodejs/node@a03aaba
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: doc/contributing/collaborator-guide.md +4-4Lines changed: 4 additions & 4 deletions - Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|
@@ -340,8 +340,8 @@ For undocumented APIs that are public, open a pull request documenting the API. |
340 | 340 |
|
341 | 341 | ### Breaking changes |
342 | 342 |
|
343 | | -At least two TSC members must approve backward-incompatible changes to the |
344 | | -`main` branch. |
| 343 | +At least two TSC voting members must approve backward-incompatible changes to |
| 344 | +the `main` branch. |
345 | 345 |
|
346 | 346 | Examples of breaking changes include: |
347 | 347 |
|
@@ -411,7 +411,7 @@ possible to avoid confusion and typosquatting attacks. |
411 | 411 | For pull requests introducing new core modules: |
412 | 412 |
|
413 | 413 | * Allow at least one week for review. |
414 | | -* Land only after sign-off from at least two TSC members. |
| 414 | +* Land only after sign-off from at least two TSC voting members. |
415 | 415 | * Land with a [Stability Index][] of Experimental. The module must remain |
416 | 416 | Experimental until a semver-major release. |
417 | 417 |
|
@@ -742,7 +742,7 @@ git push upstream main |
742 | 742 |
|
743 | 743 | ### I made a mistake |
744 | 744 |
|
745 | | -* Ping a TSC member. |
| 745 | +* Ping a TSC voting member. |
746 | 746 | * With `git`, there's a way to override remote trees by force pushing |
747 | 747 | (`git push -f`). This is generally forbidden as it creates conflicts in other |
748 | 748 | people's forks. It is permissible for simpler slip-ups such as typos in commit |
|