GeezerVison is showing github.com — net: check `autoSelectFamilyAttemptTimeout` is positive · nodejs/node@a1831da
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: lib/net.js +1-1Lines changed: 1 addition & 1 deletion | Original file line number | Diff line number | Diff line change |
|---|
@@ -1226,7 +1226,7 @@ function lookupAndConnect(self, options) { |
1226 | 1226 | } |
1227 | 1227 |
|
1228 | 1228 | if (autoSelectFamilyAttemptTimeout !== undefined) { |
1229 | | - validateInt32(autoSelectFamilyAttemptTimeout); |
| 1229 | + validateInt32(autoSelectFamilyAttemptTimeout, 'options.autoSelectFamilyAttemptTimeout', 1); |
1230 | 1230 |
|
1231 | 1231 | if (autoSelectFamilyAttemptTimeout < 10) { |
1232 | 1232 | autoSelectFamilyAttemptTimeout = 10; |
|
Collapse file
Copy file name to clipboard +14Lines changed: 14 additions & 0 deletions | Original file line number | Diff line number | Diff line change |
|---|
|
| 1 | +'use strict'; |
| 2 | +require('../common'); |
| 3 | +const assert = require('assert'); |
| 4 | +const net = require('net'); |
| 5 | + |
| 6 | +for (const autoSelectFamilyAttemptTimeout of [-10, 0]) { |
| 7 | + assert.throws(() => { |
| 8 | + net.connect({ |
| 9 | + port: 8080, |
| 10 | + autoSelectFamily: true, |
| 11 | + autoSelectFamilyAttemptTimeout, |
| 12 | + }); |
| 13 | + }, { code: 'ERR_OUT_OF_RANGE' }); |
| 14 | +} |