GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — inspector: ensure adequate memory allocation for `Binary::toBase64` · nodejs/node@a33ed9b

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

src/inspector
- node_string.cc
test/parallel
- test-inspector-network-data-received.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎src/inspector/node_string.cc‎`

Copy file name to clipboardExpand all lines: src/inspector/node_string.cc

+4-4Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -108,15 +108,15 @@ size_t StringUtil::CharacterCount(const std::string_view s) {`
`108`	`108`	`}`
`109`	`109`
`110`	`110`	`String Binary::toBase64() const {`
`111`		`- MaybeStackBuffer<char> buffer;`
`112`		`- size_t str_len = simdutf::base64_length_from_binary(bytes_->size());`
`113`		`- buffer.SetLength(str_len);`
	`111`	`+ size_t expected_base64_length =`
	`112`	`+ simdutf::base64_length_from_binary(bytes_->size());`
	`113`	`+ MaybeStackBuffer<char> buffer(expected_base64_length);`
`114`	`114`
`115`	`115`	`size_t len =`
`116`	`116`	`simdutf::binary_to_base64(reinterpret_cast<const char*>(bytes_->data()),`
`117`	`117`	`bytes_->size(),`
`118`	`118`	`buffer.out());`
`119`		`- CHECK_EQ(len, str_len);`
	`119`	`+ CHECK_EQ(len, expected_base64_length);`
`120`	`120`	`return buffer.ToString();`
`121`	`121`	`}`
`122`	`122`

Collapse file

`‎test/parallel/test-inspector-network-data-received.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-inspector-network-data-received.js

+19-5Lines changed: 19 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,9 @@ const assert = require('node:assert');`
`11`	`11`	`const { waitUntil } = require('../common/inspector-helper');`
`12`	`12`	`const { setTimeout } = require('node:timers/promises');`
`13`	`13`
	`14`	`+// The complete payload string received by the network agent`
	`15`	+const payloadString = `Hello, world${'.'.repeat(4096)}`;
	`16`	`+`
`14`	`17`	`const session = new inspector.Session();`
`15`	`18`	`session.connect();`
`16`	`19`	`session.post('Network.enable');`
`@@ -67,9 +70,20 @@ async function triggerNetworkEvents(requestId, charset) {`
`67`	`70`	`});`
`68`	`71`	`await setTimeout(1);`
`69`	`72`
`70`		`- Network.loadingFinished({`
	`73`	`+ // Test inspector binary conversions with large input`
	`74`	`+ const chunk3 = Buffer.allocUnsafe(4096).fill('.');`
	`75`	`+ Network.dataReceived({`
`71`	`76`	`requestId,`
`72`	`77`	`timestamp: 5,`
	`78`	`+ dataLength: chunk3.byteLength,`
	`79`	`+ encodedDataLength: chunk3.byteLength,`
	`80`	`+ data: chunk3,`
	`81`	`+ });`
	`82`	`+ await setTimeout(1);`
	`83`	`+`
	`84`	`+ Network.loadingFinished({`
	`85`	`+ requestId,`
	`86`	`+ timestamp: 6,`
`73`	`87`	`});`
`74`	`88`	`}`
`75`	`89`
`@@ -116,7 +130,7 @@ test('should stream Network.dataReceived with data chunks', async () => {`
`116`	`130`
`117`	`131`	`const data = Buffer.concat(chunks);`
`118`	`132`	`assert.strictEqual(data.byteLength, totalDataLength, data);`
`119`		`- assert.strictEqual(data.toString('utf8'), 'Hello, world');`
	`133`	`+ assert.strictEqual(data.toString('utf8'), payloadString);`
`120`	`134`	`});`
`121`	`135`
`122`	`136`	`test('Network.streamResourceContent should send all buffered chunks', async () => {`
`@@ -131,7 +145,7 @@ test('Network.streamResourceContent should send all buffered chunks', async () =`
`131`	`145`	`const { bufferedData } = await session.post('Network.streamResourceContent', {`
`132`	`146`	`requestId,`
`133`	`147`	`});`
`134`		`- assert.strictEqual(Buffer.from(bufferedData, 'base64').toString('utf8'), 'Hello, world');`
	`148`	`+ assert.strictEqual(Buffer.from(bufferedData, 'base64').toString('utf8'), payloadString);`
`135`	`149`	`});`
`136`	`150`
`137`	`151`	`test('Network.streamResourceContent should reject if request id not found', async () => {`
`@@ -158,7 +172,7 @@ test('Network.getResponseBody should send all buffered binary data', async () =>`
`158`	`172`	`requestId,`
`159`	`173`	`});`
`160`	`174`	`assert.strictEqual(base64Encoded, true);`
`161`		`- assert.strictEqual(body, Buffer.from('Hello, world').toString('base64'));`
	`175`	`+ assert.strictEqual(body, Buffer.from(payloadString).toString('base64'));`
`162`	`176`	`});`
`163`	`177`
`164`	`178`	`test('Network.getResponseBody should send all buffered text data', async () => {`
`@@ -174,5 +188,5 @@ test('Network.getResponseBody should send all buffered text data', async () => {`
`174`	`188`	`requestId,`
`175`	`189`	`});`
`176`	`190`	`assert.strictEqual(base64Encoded, false);`
`177`		`- assert.strictEqual(body, 'Hello, world');`
	`191`	`+ assert.strictEqual(body, payloadString);`
`178`	`192`	`});`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.