GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — http2: fix crash on Http2Stream::diagnostic_name() · nodejs/node@a534175

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • src
    • node_http2.cc
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/node_http2.cc‎

Copy file name to clipboardExpand all lines: src/node_http2.cc
+5-2Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2060,9 +2060,12 @@ void Http2Stream::MemoryInfo(MemoryTracker* tracker) const {
20602060
}
20612061

20622062
std::string Http2Stream::diagnostic_name() const {
2063+
const Http2Session* sess = session();
2064+
const std::string sname =
2065+
sess ? sess->diagnostic_name() : "session already destroyed";
20632066
return "HttpStream " + std::to_string(id()) + " (" +
2064-
std::to_string(static_cast<int64_t>(get_async_id())) + ") [" +
2065-
session()->diagnostic_name() + "]";
2067+
std::to_string(static_cast<int64_t>(get_async_id())) + ") [" + sname +
2068+
"]";
20662069
}
20672070

20682071
// Notify the Http2Stream that a new block of HEADERS is being processed.

0 commit comments

Comments
0 (0)
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.