GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — build: drop experimental support for Windows <10 · nodejs/node@a5decd4

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • BUILDING.md
  • src
    • node_main.cc
  • tools/v8_gypfiles
    • toolchain.gypi
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎BUILDING.md‎

Copy file name to clipboardExpand all lines: BUILDING.md
-1Lines changed: 0 additions & 1 deletion
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,6 @@ platforms. This is true regardless of entries in the table below.
112112
| GNU/Linux | s390x | kernel >= 4.18[^1], glibc >= 2.28 | Tier 2 | e.g. RHEL 8 |
113113
| GNU/Linux | loong64 | kernel >= 5.19, glibc >= 2.36 | Experimental | |
114114
| Windows | x64 | >= Windows 10/Server 2016 | Tier 1 | [^2],[^3] |
115-
| Windows | x64 | Windows 8.1/Server 2012 | Experimental | |
116115
| Windows | arm64 | >= Windows 10 | Tier 2 | |
117116
| macOS | x64 | >= 11.0 | Tier 1 | For notes about compilation see [^4] |
118117
| macOS | arm64 | >= 11.0 | Tier 1 | |
Collapse file

‎src/node_main.cc‎

Copy file name to clipboardExpand all lines: src/node_main.cc
+8-8Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,17 +35,17 @@ int wmain(int argc, wchar_t* wargv[]) {
3535
// Windows Server 2012 (not R2) is supported until 10/10/2023, so we allow it
3636
// to run in the experimental support tier.
3737
char buf[SKIP_CHECK_STRLEN + 1];
38-
if (!IsWindows8Point1OrGreater() &&
39-
!(IsWindowsServer() && IsWindows8OrGreater()) &&
38+
if (!IsWindows10OrGreater() &&
4039
(GetEnvironmentVariableA(SKIP_CHECK_VAR, buf, sizeof(buf)) !=
4140
SKIP_CHECK_STRLEN ||
4241
strncmp(buf, SKIP_CHECK_VALUE, SKIP_CHECK_STRLEN) != 0)) {
43-
fprintf(stderr, "Node.js is only supported on Windows 8.1, Windows "
44-
"Server 2012 R2, or higher.\n"
45-
"Setting the " SKIP_CHECK_VAR " environment variable "
46-
"to 1 skips this\ncheck, but Node.js might not execute "
47-
"correctly. Any issues encountered on\nunsupported "
48-
"platforms will not be fixed.");
42+
fprintf(stderr,
43+
"Node.js is only supported on Windows 10, Windows "
44+
"Server 2016, or higher.\n"
45+
"Setting the " SKIP_CHECK_VAR " environment variable "
46+
"to 1 skips this\ncheck, but Node.js might not execute "
47+
"correctly. Any issues encountered on\nunsupported "
48+
"platforms will not be fixed.");
4949
exit(ERROR_EXE_MACHINE_TYPE_MISMATCH);
5050
}
5151

Collapse file

‎tools/v8_gypfiles/toolchain.gypi‎

Copy file name to clipboardExpand all lines: tools/v8_gypfiles/toolchain.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -540,7 +540,7 @@
540540
'defines': [
541541
'WIN32',
542542
'NOMINMAX', # Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1456620
543-
'_WIN32_WINNT=0x0602', # Windows 8
543+
'_WIN32_WINNT=0x0A00', # Windows 10
544544
'_SILENCE_ALL_CXX20_DEPRECATION_WARNINGS',
545545
],
546546
# 4351: VS 2005 and later are warning us that they've fixed a bug

0 commit comments

Comments
0 (0)
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.