GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — lib: define Event.isTrusted in the prototype · nodejs/node@a738164

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

lib/internal
- event_target.js
test
- parallel
- wpt/status/dom
  - events.json

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎lib/internal/event_target.js‎`

Copy file name to clipboardExpand all lines: lib/internal/event_target.js

+5-2Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -119,8 +119,6 @@ class Event {`
`119`	`119`	`isTrustedSet.add(this);`
`120`	`120`	`}`
`121`	`121`
`122`		`- // isTrusted is special (LegacyUnforgeable)`
`123`		`- ObjectDefineProperty(this, 'isTrusted', isTrustedDescriptor);`
`124`	`122`	`this[kTarget] = null;`
`125`	`123`	`this[kIsBeingDispatched] = false;`
`126`	`124`	`}`
`@@ -343,6 +341,11 @@ ObjectDefineProperties(`
`343`	`341`	`eventPhase: kEnumerableProperty,`
`344`	`342`	`cancelBubble: kEnumerableProperty,`
`345`	`343`	`stopPropagation: kEnumerableProperty,`
	`344`	`+ // Don't conform to the spec with isTrusted. The spec defines it as`
	`345`	`+ // LegacyUnforgeable but defining it in the constructor has a big`
	`346`	`+ // performance impact and the property doesn't seem to be useful outside of`
	`347`	`+ // browsers.`
	`348`	`+ isTrusted: isTrustedDescriptor,`
`346`	`349`	`});`
`347`	`350`
`348`	`351`	`function isCustomEvent(value) {`

Collapse file

`‎test/parallel/test-abortcontroller.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-abortcontroller.js

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -57,9 +57,9 @@ const { setTimeout: sleep } = require('timers/promises');`
`57`	`57`	`}));`
`58`	`58`	`first.abort();`
`59`	`59`	`second.abort();`
`60`		`- const firstTrusted = Reflect.getOwnPropertyDescriptor(ev1, 'isTrusted').get;`
`61`		`- const secondTrusted = Reflect.getOwnPropertyDescriptor(ev2, 'isTrusted').get;`
`62`		`- const untrusted = Reflect.getOwnPropertyDescriptor(ev3, 'isTrusted').get;`
	`60`	`+ const firstTrusted = Reflect.getOwnPropertyDescriptor(Object.getPrototypeOf(ev1), 'isTrusted').get;`
	`61`	`+ const secondTrusted = Reflect.getOwnPropertyDescriptor(Object.getPrototypeOf(ev2), 'isTrusted').get;`
	`62`	`+ const untrusted = Reflect.getOwnPropertyDescriptor(Object.getPrototypeOf(ev3), 'isTrusted').get;`
`63`	`63`	`strictEqual(firstTrusted, secondTrusted);`
`64`	`64`	`strictEqual(untrusted, firstTrusted);`
`65`	`65`	`}`

Collapse file

`‎test/parallel/test-events-customevent.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-events-customevent.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ const { Event, EventTarget, CustomEvent } = require('internal/event_target');`
`187`	`187`	`}`
`188`	`188`	`{`
`189`	`189`	`const ev = new CustomEvent('foo');`
`190`		`- deepStrictEqual(Object.keys(ev), ['isTrusted']);`
	`190`	`+ strictEqual(ev.isTrusted, false);`
`191`	`191`	`}`
`192`	`192`
`193`	`193`	`// Works with EventTarget`

Collapse file

`‎test/parallel/test-eventtarget.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-eventtarget.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ let asyncTest = Promise.resolve();`
`126`	`126`	`}`
`127`	`127`	`{`
`128`	`128`	`const ev = new Event('foo');`
`129`		`- deepStrictEqual(Object.keys(ev), ['isTrusted']);`
	`129`	`+ strictEqual(ev.isTrusted, false);`
`130`	`130`	`}`
`131`	`131`	`{`
`132`	`132`	`const eventTarget = new EventTarget();`

Collapse file

`‎test/wpt/status/dom/events.json‎`

Copy file name to clipboardExpand all lines: test/wpt/status/dom/events.json

+7Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,13 @@`
`11`	`11`	`"Event-dispatch-listener-order.window.js": {`
`12`	`12`	`"skip": "document is not defined"`
`13`	`13`	`},`
	`14`	`+ "Event-isTrusted.any.js": {`
	`15`	`+ "fail": {`
	`16`	`+ "expected": [`
	`17`	`+ "Event-isTrusted"`
	`18`	`+ ]`
	`19`	`+ }`
	`20`	`+ },`
`14`	`21`	`"EventListener-addEventListener.sub.window.js": {`
`15`	`22`	`"skip": "document is not defined"`
`16`	`23`	`},`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.