GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — child_process: support AbortSignal in fork · nodejs/node@a8a427f

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

doc/api
- child_process.md
lib
- child_process.js
test
- fixtures
  - child-process-stay-alive-forever.js
- parallel
  - test-child-process-fork-abort-signal.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎doc/api/child_process.md‎`

Copy file name to clipboardExpand all lines: doc/api/child_process.md

+9-2Lines changed: 9 additions & 2 deletions

Display the source diff
Display the rich diff

Original file line number	Diff line number	Diff line change
`@@ -351,6 +351,9 @@ controller.abort();`
`351`	`351`	`<!-- YAML`
`352`	`352`	`added: v0.5.0`
`353`	`353`	`changes:`
	`354`	`+ - version: REPLACEME`
	`355`	`+ pr-url: https://github.com/nodejs/node/pull/36603`
	`356`	`+ description: AbortSignal support was added.`
`354`	`357`	`- version:`
`355`	`358`	`- v13.2.0`
`356`	`359`	`- v12.16.0`
`@@ -375,9 +378,11 @@ changes:`
`375`	`378`	* `execPath` {string} Executable used to create the child process.
`376`	`379`	* `execArgv` {string[]} List of string arguments passed to the executable.
`377`	`380`	Default: `process.execArgv`.
	`381`	+ * `gid` {number} Sets the group identity of the process (see setgid(2)).
`378`	`382`	* `serialization` {string} Specify the kind of serialization used for sending
`379`	`383`	messages between processes. Possible values are `'json'` and `'advanced'`.
`380`	`384`	See [Advanced serialization][] for more details. Default: `'json'`.
	`385`	+ * `signal` {AbortSignal} Allows closing the subprocess using an AbortSignal.
`381`	`386`	* `silent` {boolean} If `true`, stdin, stdout, and stderr of the child will be
`382`	`387`	`piped to the parent, otherwise they will be inherited from the parent, see`
`383`	`388`	the `'pipe'` and `'inherit'` options for [`child_process.spawn()`][]'s
`@@ -386,10 +391,9 @@ changes:`
`386`	`391`	When this option is provided, it overrides `silent`. If the array variant
`387`	`392`	is used, it must contain exactly one item with value `'ipc'` or an error
`388`	`393`	will be thrown. For instance `[0, 1, 2, 'ipc']`.
	`394`	+ * `uid` {number} Sets the user identity of the process (see setuid(2)).
`389`	`395`	* `windowsVerbatimArguments` {boolean} No quoting or escaping of arguments is
`390`	`396`	done on Windows. Ignored on Unix. Default: `false`.
`391`		- * `uid` {number} Sets the user identity of the process (see setuid(2)).
`392`		- * `gid` {number} Sets the group identity of the process (see setgid(2)).
`393`	`397`	`* Returns: {ChildProcess}`
`394`	`398`
`395`	`399`	The `child_process.fork()` method is a special case of
`@@ -420,6 +424,9 @@ current process.`
`420`	`424`	The `shell` option available in [`child_process.spawn()`][] is not supported by
`421`	`425`	`child_process.fork()` and will be ignored if set.
`422`	`426`
	`427`	+The `signal` option works exactly the same way it does in
	`428`	+[`child_process.spawn()`][].
	`429`	`+`
`423`	`430`	### `child_process.spawn(command[, args][, options])`
`424`	`431`	`<!-- YAML`
`425`	`432`	`added: v0.1.90`

Collapse file

`‎lib/child_process.js‎`

Copy file name to clipboardExpand all lines: lib/child_process.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ function fork(modulePath /* , args, options */) {`
`140`	`140`	`options.execPath = options.execPath \|\| process.execPath;`
`141`	`141`	`options.shell = false;`
`142`	`142`
`143`		`- return spawn(options.execPath, args, options);`
	`143`	`+ return spawnWithSignal(options.execPath, args, options);`
`144`	`144`	`}`
`145`	`145`
`146`	`146`	`function _forkChild(fd, serializationMode) {`
`@@ -758,7 +758,7 @@ function spawnWithSignal(file, args, options) {`
`758`	`758`	`validateAbortSignal(options.signal, 'options.signal');`
`759`	`759`	`function kill() {`
`760`	`760`	`if (child._handle) {`
`761`		`- child._handle.kill('SIGTERM');`
	`761`	`+ child.kill('SIGTERM');`
`762`	`762`	`child.emit('error', new AbortError());`
`763`	`763`	`}`
`764`	`764`	`}`

Collapse file

`‎test/fixtures/child-process-stay-alive-forever.js‎`

Copy file name to clipboard

+3Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+setInterval(() => {`
	`2`	`+ // Starting an interval to stay alive.`
	`3`	`+}, 1000);`

Collapse file

`‎test/parallel/test-child-process-fork-abort-signal.js‎`

Copy file name to clipboard

+33Lines changed: 33 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,33 @@`
	`1`	`+'use strict';`
	`2`	`+`
	`3`	`+const { mustCall } = require('../common');`
	`4`	`+const { strictEqual } = require('assert');`
	`5`	`+const fixtures = require('../common/fixtures');`
	`6`	`+const { fork } = require('child_process');`
	`7`	`+`
	`8`	`+{`
	`9`	`+ // Test aborting a forked child_process after calling fork`
	`10`	`+ const ac = new AbortController();`
	`11`	`+ const { signal } = ac;`
	`12`	`+ const cp = fork(fixtures.path('child-process-stay-alive-forever.js'), {`
	`13`	`+ signal`
	`14`	`+ });`
	`15`	`+ cp.on('exit', mustCall());`
	`16`	`+ cp.on('error', mustCall((err) => {`
	`17`	`+ strictEqual(err.name, 'AbortError');`
	`18`	`+ }));`
	`19`	`+ process.nextTick(() => ac.abort());`
	`20`	`+}`
	`21`	`+{`
	`22`	`+ // Test passing an already aborted signal to a forked child_process`
	`23`	`+ const ac = new AbortController();`
	`24`	`+ const { signal } = ac;`
	`25`	`+ ac.abort();`
	`26`	`+ const cp = fork(fixtures.path('child-process-stay-alive-forever.js'), {`
	`27`	`+ signal`
	`28`	`+ });`
	`29`	`+ cp.on('exit', mustCall());`
	`30`	`+ cp.on('error', mustCall((err) => {`
	`31`	`+ strictEqual(err.name, 'AbortError');`
	`32`	`+ }));`
	`33`	`+}`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.