GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> · nodejs/node@aab4adb

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

src
- node_builtins.cc
- node_builtins.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎src/node_builtins.cc‎`

Copy file name to clipboardExpand all lines: src/node_builtins.cc

+4-3Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@ using v8::FunctionCallbackInfo;`
`19`	`19`	`using v8::IntegrityLevel;`
`20`	`20`	`using v8::Isolate;`
`21`	`21`	`using v8::Local;`
	`22`	`+using v8::LocalVector;`
`22`	`23`	`using v8::MaybeLocal;`
`23`	`24`	`using v8::Name;`
`24`	`25`	`using v8::NewStringType;`
`@@ -262,7 +263,7 @@ void BuiltinLoader::AddExternalizedBuiltin(const char* id,`
`262`	`263`	`MaybeLocal<Function> BuiltinLoader::LookupAndCompileInternal(`
`263`	`264`	`Local<Context> context,`
`264`	`265`	`const char* id,`
`265`		`- std::vector<Local<String>>* parameters,`
	`266`	`+ LocalVector<String>* parameters,`
`266`	`267`	`Realm* optional_realm) {`
`267`	`268`	`Isolate* isolate = context->GetIsolate();`
`268`	`269`	`EscapableHandleScope scope(isolate);`
`@@ -386,8 +387,8 @@ void BuiltinLoader::SaveCodeCache(const char* id, Local<Function> fun) {`
`386`	`387`	`MaybeLocal<Function> BuiltinLoader::LookupAndCompile(Local<Context> context,`
`387`	`388`	`const char* id,`
`388`	`389`	`Realm* optional_realm) {`
`389`		`- std::vector<Local<String>> parameters;`
`390`	`390`	`Isolate* isolate = context->GetIsolate();`
	`391`	`+ LocalVector<String> parameters(isolate);`
`391`	`392`	`// Detects parameters of the scripts based on module ids.`
`392`	`393`	`// internal/bootstrap/realm: process, getLinkedBinding,`
`393`	`394`	`// getInternalBinding, primordials`
`@@ -502,7 +503,7 @@ MaybeLocal<Value> BuiltinLoader::CompileAndCall(Local<Context> context,`
`502`	`503`	`MaybeLocal<Function> BuiltinLoader::LookupAndCompile(`
`503`	`504`	`Local<Context> context,`
`504`	`505`	`const char* id,`
`505`		`- std::vector<Local<String>>* parameters,`
	`506`	`+ LocalVector<String>* parameters,`
`506`	`507`	`Realm* optional_realm) {`
`507`	`508`	`return LookupAndCompileInternal(context, id, parameters, optional_realm);`
`508`	`509`	`}`

Collapse file

`‎src/node_builtins.h‎`

Copy file name to clipboardExpand all lines: src/node_builtins.h

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ class NODE_EXTERN_PRIVATE BuiltinLoader {`
`101`	`101`	`v8::MaybeLocal<v8::Function> LookupAndCompile(`
`102`	`102`	`v8::Local<v8::Context> context,`
`103`	`103`	`const char* id,`
`104`		`- std::vector<v8::Local<v8::String>>* parameters,`
	`104`	`+ v8::LocalVector<v8::String>* parameters,`
`105`	`105`	`Realm* optional_realm);`
`106`	`106`
`107`	`107`	`v8::MaybeLocal<v8::Value> CompileAndCall(v8::Local<v8::Context> context,`
`@@ -159,7 +159,7 @@ class NODE_EXTERN_PRIVATE BuiltinLoader {`
`159`	`159`	`v8::MaybeLocal<v8::Function> LookupAndCompileInternal(`
`160`	`160`	`v8::Local<v8::Context> context,`
`161`	`161`	`const char* id,`
`162`		`- std::vector<v8::Local<v8::String>>* parameters,`
	`162`	`+ v8::LocalVector<v8::String>* parameters,`
`163`	`163`	`Realm* optional_realm);`
`164`	`164`	`void SaveCodeCache(const char* id, v8::Local<v8::Function> fn);`
`165`	`165`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.