GeezerVison is showing github.com — doc: mention adding Fixes to collaborator onboarding PR · nodejs/node@b353549
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: onboarding.md +6-3Lines changed: 6 additions & 3 deletions - Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|
@@ -204,11 +204,14 @@ needs to be pointed out separately during the onboarding. |
204 | 204 | ## Exercise: Make a PR adding yourself to the README |
205 | 205 |
|
206 | 206 | * Example: |
207 | | - <https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0> |
208 | | - * For raw commit message: `git log ce986de829457c39257cd205067602e765768fb0 |
209 | | - -1` |
| 207 | + <https://github.com/nodejs/node/commit/b58fe52692659c0bc25ddbe6afa7f4ae2c7f14a8> |
| 208 | + * For raw commit message: |
| 209 | + `git show --format=%Bb58fe52692659c0bc25ddbe6afa7f4ae2c7f14a8` |
210 | 210 | * Collaborators are in alphabetical order by GitHub username. |
211 | 211 | * Optionally, include your personal pronouns. |
| 212 | +* Add the `Fixes: <collaborator-nomination-issue-url>` to the commit message |
| 213 | + so that when the commit lands, the nomination issue url will be |
| 214 | + automatically closed. |
212 | 215 | * Label your pull request with the `doc`, `notable-change`, and `fast-track` |
213 | 216 | labels. |
214 | 217 | * Run CI on the PR. Use the `node-test-pull-request` CI task. |
|