GeezerVison is showing github.com — benchmark: use let instead of var in zlib · nodejs/node@b556670
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: benchmark/zlib/creation.js +2-3Lines changed: 2 additions & 3 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -15,17 +15,16 @@ function main({ n, type, options }) { |
15 | 15 | const fn = zlib[`create${type}`]; |
16 | 16 | if (typeof fn !== 'function') |
17 | 17 | throw new Error('Invalid zlib type'); |
18 | | - var i = 0; |
19 | 18 |
|
20 | 19 | if (options === 'true') { |
21 | 20 | const opts = {}; |
22 | 21 | bench.start(); |
23 | | - for (; i < n; ++i) |
| 22 | + for (let i = 0; i < n; ++i) |
24 | 23 | fn(opts); |
25 | 24 | bench.end(n); |
26 | 25 | } else { |
27 | 26 | bench.start(); |
28 | | - for (; i < n; ++i) |
| 27 | + for (let i = 0; i < n; ++i) |
29 | 28 | fn(); |
30 | 29 | bench.end(n); |
31 | 30 | } |
|
Collapse file
Copy file name to clipboardExpand all lines: benchmark/zlib/deflate.js +12-8Lines changed: 12 additions & 8 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -13,11 +13,11 @@ function main({ n, method, inputLen }) { |
13 | 13 | method = method || 'deflate'; |
14 | 14 | const chunk = Buffer.alloc(inputLen, 'a'); |
15 | 15 |
|
16 | | - var i = 0; |
17 | 16 | switch (method) { |
18 | 17 | // Performs `n` writes for a single deflate stream |
19 | | - case 'createDeflate': |
20 | | - var deflater = zlib.createDeflate(); |
| 18 | + case 'createDeflate': { |
| 19 | + let i = 0; |
| 20 | + const deflater = zlib.createDeflate(); |
21 | 21 | deflater.resume(); |
22 | 22 | deflater.on('finish', () => { |
23 | 23 | bench.end(n); |
@@ -30,24 +30,28 @@ function main({ n, method, inputLen }) { |
30 | 30 | deflater.write(chunk, next); |
31 | 31 | })(); |
32 | 32 | break; |
| 33 | + } |
33 | 34 | // Performs `n` single deflate operations |
34 | | - case 'deflate': |
35 | | - var deflate = zlib.deflate; |
| 35 | + case 'deflate': { |
| 36 | + let i = 0; |
| 37 | + const deflate = zlib.deflate; |
36 | 38 | bench.start(); |
37 | 39 | (function next(err, result) { |
38 | 40 | if (i++ === n) |
39 | 41 | return bench.end(n); |
40 | 42 | deflate(chunk, next); |
41 | 43 | })(); |
42 | 44 | break; |
| 45 | + } |
43 | 46 | // Performs `n` single deflateSync operations |
44 | | - case 'deflateSync': |
45 | | - var deflateSync = zlib.deflateSync; |
| 47 | + case 'deflateSync': { |
| 48 | + const deflateSync = zlib.deflateSync; |
46 | 49 | bench.start(); |
47 | | - for (; i < n; ++i) |
| 50 | + for (let i = 0; i < n; ++i) |
48 | 51 | deflateSync(chunk); |
49 | 52 | bench.end(n); |
50 | 53 | break; |
| 54 | + } |
51 | 55 | default: |
52 | 56 | throw new Error('Unsupported deflate method'); |
53 | 57 | } |
|