GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — esm: rename `URLCanParse` to be consistent · nodejs/node@b61efcc

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

lib/internal/modules/esm
- hooks.js
- resolve.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎lib/internal/modules/esm/hooks.js‎`

Copy file name to clipboardExpand all lines: lib/internal/modules/esm/hooks.js

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ const {`
`33`	`33`	`ERR_WORKER_UNSERIALIZABLE_ERROR,`
`34`	`34`	`} = require('internal/errors').codes;`
`35`	`35`	`const { URL } = require('internal/url');`
`36`		`-const { canParse: urlCanParse } = internalBinding('url');`
	`36`	`+const { canParse: URLCanParse } = internalBinding('url');`
`37`	`37`	`const { receiveMessageOnPort } = require('worker_threads');`
`38`	`38`	`const {`
`39`	`39`	`isAnyArrayBuffer,`
`@@ -272,7 +272,7 @@ class Hooks {`
`272`	`272`	`// Avoid expensive URL instantiation for known-good URLs`
`273`	`273`	`if (!this.#validatedUrls.has(url)) {`
`274`	`274`	`// No need to convert to string, since the type is already validated`
`275`		`- if (!urlCanParse(url)) {`
	`275`	`+ if (!URLCanParse(url)) {`
`276`	`276`	`throw new ERR_INVALID_RETURN_PROPERTY_VALUE(`
`277`	`277`	`'a URL string',`
`278`	`278`	`hookErrIdentifier,`
`@@ -351,7 +351,7 @@ class Hooks {`
`351`	`351`	`// Avoid expensive URL instantiation for known-good URLs`
`352`	`352`	`if (!this.#validatedUrls.has(nextUrl)) {`
`353`	`353`	`// No need to convert to string, since the type is already validated`
`354`		`- if (!urlCanParse(nextUrl)) {`
	`354`	`+ if (!URLCanParse(nextUrl)) {`
`355`	`355`	`throw new ERR_INVALID_ARG_VALUE(`
`356`	`356`	`${hookErrIdentifier} url`,
`357`	`357`	`nextUrl,`

Collapse file

`‎lib/internal/modules/esm/resolve.js‎`

Copy file name to clipboardExpand all lines: lib/internal/modules/esm/resolve.js

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -38,8 +38,8 @@ const preserveSymlinksMain = getOptionValue('--preserve-symlinks-main');`
`38`	`38`	`const experimentalNetworkImports =`
`39`	`39`	`getOptionValue('--experimental-network-imports');`
`40`	`40`	`const typeFlag = getOptionValue('--input-type');`
`41`		`-const { URL, pathToFileURL, fileURLToPath, toPathIfFileURL, isURL } = require('internal/url');`
`42`		`-const { canParse: canParseURL } = internalBinding('url');`
	`41`	`+const { URL, pathToFileURL, fileURLToPath, isURL, toPathIfFileURL } = require('internal/url');`
	`42`	`+const { canParse: URLCanParse } = internalBinding('url');`
`43`	`43`	`const {`
`44`	`44`	`ERR_INPUT_TYPE_NOT_ALLOWED,`
`45`	`45`	`ERR_INVALID_ARG_TYPE,`
`@@ -395,7 +395,7 @@ function resolvePackageTargetString(`
`395`	`395`	`if (internal && !StringPrototypeStartsWith(target, '../') &&`
`396`	`396`	`!StringPrototypeStartsWith(target, '/')) {`
`397`	`397`	`// No need to convert target to string, since it's already presumed to be`
`398`		`- if (!canParseURL(target)) {`
	`398`	`+ if (!URLCanParse(target)) {`
`399`	`399`	`const exportTarget = pattern ?`
`400`	`400`	`RegExpPrototypeSymbolReplace(patternRegEx, target, () => subpath) :`
`401`	`401`	`target + subpath;`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.