GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: use assert.{s,deepS}trictEqual() · nodejs/node@b85b13b

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • test/parallel
    • test-tls-set-sigalgs.js
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎test/parallel/test-tls-set-sigalgs.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-tls-set-sigalgs.js
+10-12Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,6 @@ const {
99
assert, connect, keys
1010
} = require(fixtures.path('tls-connect'));
1111

12-
function assert_arrays_equal(left, right) {
13-
assert.strictEqual(left.length, right.length);
14-
for (let i = 0; i < left.length; i++) {
15-
assert.strictEqual(left[i], right[i]);
16-
}
17-
}
18-
1912
function test(csigalgs, ssigalgs, shared_sigalgs, cerr, serr) {
2013
assert(shared_sigalgs || serr || cerr, 'test missing any expectations');
2114
connect({
@@ -43,16 +36,19 @@ function test(csigalgs, ssigalgs, shared_sigalgs, cerr, serr) {
4336
assert.ifError(pair.client.err);
4437
assert(pair.server.conn);
4538
assert(pair.client.conn);
46-
assert_arrays_equal(pair.server.conn.getSharedSigalgs(), shared_sigalgs);
39+
assert.deepStrictEqual(
40+
pair.server.conn.getSharedSigalgs(),
41+
shared_sigalgs
42+
);
4743
} else {
4844
if (serr) {
4945
assert(pair.server.err);
50-
assert(pair.server.err.code, serr);
46+
assert.strictEqual(pair.server.err.code, serr);
5147
}
5248

5349
if (cerr) {
5450
assert(pair.client.err);
55-
assert(pair.client.err.code, cerr);
51+
assert.strictEqual(pair.client.err.code, cerr);
5652
}
5753
}
5854

@@ -68,7 +64,9 @@ test('RSA-PSS+SHA256:RSA-PSS+SHA512:ECDSA+SHA256',
6864

6965
// Do not have shared sigalgs.
7066
test('RSA-PSS+SHA384', 'ECDSA+SHA256',
71-
undefined, 'ECONNRESET', 'ERR_SSL_NO_SHARED_SIGNATURE_ALGORITHMS');
67+
undefined, 'ERR_SSL_SSLV3_ALERT_HANDSHAKE_FAILURE',
68+
'ERR_SSL_NO_SHARED_SIGNATURE_ALGORITHMS');
7269

7370
test('RSA-PSS+SHA384:ECDSA+SHA256', 'ECDSA+SHA384:RSA-PSS+SHA256',
74-
undefined, 'ECONNRESET', 'ERR_SSL_NO_SHARED_SIGNATURE_ALGORITHMS');
71+
undefined, 'ERR_SSL_SSLV3_ALERT_HANDSHAKE_FAILURE',
72+
'ERR_SSL_NO_SHARED_SIGNATURE_ALGORITHMS');

0 commit comments

Comments
0 (0)
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.