GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: patch V8 to 14.3.127.16 · nodejs/node@bfc729c

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • deps/v8
    • include
      • v8-version.h
    • src
      • objects
        • intl-objects.cc
      • wasm
        • wasm-objects.cc
        • wasm-objects.h
    • test/intl/date-format
      • long-locale.js
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎deps/v8/include/v8-version.h‎

Copy file name to clipboardExpand all lines: deps/v8/include/v8-version.h
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#define V8_MAJOR_VERSION 14
1212
#define V8_MINOR_VERSION 3
1313
#define V8_BUILD_NUMBER 127
14-
#define V8_PATCH_LEVEL 14
14+
#define V8_PATCH_LEVEL 16
1515

1616
// Use 1 for candidates and 0 otherwise.
1717
// (Boolean macro values are not supported by all preprocessors.)
Collapse file

‎deps/v8/src/objects/intl-objects.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/objects/intl-objects.cc
+6-2Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2445,7 +2445,7 @@ std::map<std::string, std::string> LookupAndValidateUnicodeExtensions(
24452445
if (U_FAILURE(status)) return extensions;
24462446

24472447
if (!keywords) return extensions;
2448-
char value[ULOC_FULLNAME_CAPACITY];
2448+
char value[ULOC_FULLNAME_CAPACITY + 1];
24492449

24502450
int32_t length;
24512451
status = U_ZERO_ERROR;
@@ -2459,7 +2459,8 @@ std::map<std::string, std::string> LookupAndValidateUnicodeExtensions(
24592459
continue;
24602460
}
24612461

2462-
icu_locale->getKeywordValue(keyword, value, ULOC_FULLNAME_CAPACITY, status);
2462+
const int32_t value_len = icu_locale->getKeywordValue(
2463+
keyword, value, ULOC_FULLNAME_CAPACITY, status);
24632464

24642465
// Ignore failures in ICU and skip to the next keyword.
24652466
//
@@ -2468,6 +2469,9 @@ std::map<std::string, std::string> LookupAndValidateUnicodeExtensions(
24682469
status = U_ZERO_ERROR;
24692470
continue;
24702471
}
2472+
// Ensure the `value` is null-terminated even when the `status` is
2473+
// `U_STRING_NOT_TERMINATED_WARNING`.
2474+
value[value_len] = '\0';
24712475

24722476
const char* bcp47_key = uloc_toUnicodeLocaleKey(keyword);
24732477

Collapse file

‎deps/v8/src/wasm/wasm-objects.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/wasm/wasm-objects.cc
+4-2Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2497,7 +2497,8 @@ void SetForNonWrapper(Tagged<DispatchTable> dispatch_table, int index,
24972497
} else {
24982498
#if V8_ENABLE_DRUMBRAKE
24992499
// Ignore call_target, not used in jitless mode.
2500-
WriteField<int>(offset + kFunctionIndexBias, function_index);
2500+
dispatch_table->template WriteField<int>(
2501+
offset + DispatchTable::kFunctionIndexBias, function_index);
25012502
#endif // V8_ENABLE_DRUMBRAKE
25022503
}
25032504
dispatch_table->WriteProtectedPointerField(
@@ -2578,7 +2579,8 @@ void SetForWrapper(
25782579
} else {
25792580
#if V8_ENABLE_DRUMBRAKE
25802581
// Ignore call_target, not used in jitless mode.
2581-
WriteField<int>(offset + kFunctionIndexBias, function_index);
2582+
dispatch_table->template WriteField<int>(
2583+
offset + DispatchTable::kFunctionIndexBias, function_index);
25822584
#endif // V8_ENABLE_DRUMBRAKE
25832585
}
25842586
if constexpr (requires { DispatchTable::kSigBias; }) {
Collapse file

‎deps/v8/src/wasm/wasm-objects.h‎

Copy file name to clipboardExpand all lines: deps/v8/src/wasm/wasm-objects.h
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -961,10 +961,9 @@ class WasmDispatchTableForImports : public TrustedObject {
961961
// In jitless mode, reuse the 'target' field storage to hold the (uint32_t)
962962
// function index.
963963
static constexpr size_t kFunctionIndexBias = kTargetBias;
964-
#else
964+
#endif // V8_ENABLE_DRUMBRAKE
965965
static constexpr size_t kEntryPaddingSize =
966966
TAGGED_SIZE_8_BYTES ? kUInt32Size : 0;
967-
#endif // V8_ENABLE_DRUMBRAKE
968967
static_assert(sizeof(WasmCodePointer) == kUInt32Size);
969968
static constexpr size_t kImplicitArgBias =
970969
kTargetBias + kEntryPaddingSize + kUInt32Size;
Collapse file

‎deps/v8/test/intl/date-format/long-locale.js‎

Copy file name to clipboard
+15Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
// Copyright 2025 the V8 project authors. All rights reserved.
2+
// Use of this source code is governed by a BSD-style license that can be
3+
// found in the LICENSE file.
4+
5+
let locale = "zh-TW-u-ca-chinese";
6+
for (let i = 0; i < 300; ++i) {
7+
try {
8+
Intl.DateTimeFormat(locale);
9+
} catch (e) {
10+
// "RangeError: Invalid language tag", for locales ending with "-", or
11+
// sub-tags of one character, are not relevant to this test.
12+
}
13+
locale += (i % 5) ? "a" : "-";
14+
}
15+
// Pass if this test doesn't crash.

0 commit comments

Comments
0 (0)
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.