GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — report: add missing locks for report_on_fatalerror accessors · nodejs/node@c095520

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • src
    • node_report_module.cc
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/node_report_module.cc‎

Copy file name to clipboardExpand all lines: src/node_report_module.cc
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
namespace report {
1818
using node::Environment;
19+
using node::Mutex;
1920
using node::Utf8Value;
2021
using v8::Boolean;
2122
using v8::Context;
@@ -134,12 +135,14 @@ static void SetSignal(const FunctionCallbackInfo<Value>& info) {
134135
}
135136

136137
static void ShouldReportOnFatalError(const FunctionCallbackInfo<Value>& info) {
138+
Mutex::ScopedLock lock(node::per_process::cli_options_mutex);
137139
info.GetReturnValue().Set(
138140
node::per_process::cli_options->report_on_fatalerror);
139141
}
140142

141143
static void SetReportOnFatalError(const FunctionCallbackInfo<Value>& info) {
142144
CHECK(info[0]->IsBoolean());
145+
Mutex::ScopedLock lock(node::per_process::cli_options_mutex);
143146
node::per_process::cli_options->report_on_fatalerror = info[0]->IsTrue();
144147
}
145148

0 commit comments

Comments
0 (0)
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.