GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tls: avoid throw in onerror for bad TLSSocket obj · nodejs/node@c498a72

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • lib
    • _tls_wrap.js
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎lib/_tls_wrap.js‎

Copy file name to clipboardExpand all lines: lib/_tls_wrap.js
+5-3Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -408,8 +408,10 @@ function onocspresponse(resp) {
408408
function onerror(err) {
409409
const owner = this[owner_symbol];
410410
debug('%s onerror %s had? %j',
411-
owner._tlsOptions.isServer ? 'server' : 'client', err,
412-
owner._hadError);
411+
(typeof owner._tlsOptions === 'object' && owner._tlsOptions !== null) ?
412+
owner._tlsOptions.isServer ? 'server' : 'client' :
413+
'unknown',
414+
err, owner._hadError);
413415

414416
if (owner._hadError)
415417
return;
@@ -421,7 +423,7 @@ function onerror(err) {
421423
// When handshake fails control is not yet released,
422424
// so self._tlsError will return null instead of actual error
423425
owner.destroy(err);
424-
} else if (owner._tlsOptions.isServer &&
426+
} else if (owner._tlsOptions?.isServer &&
425427
owner._rejectUnauthorized &&
426428
RegExpPrototypeTest(/peer did not return a certificate/,
427429
err.message)) {

0 commit comments

Comments
0 (0)
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.