GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — src: use context-free V8 message column getters · nodejs/node@c70ff44

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

src
- inspector_agent.cc
- node_errors.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎src/inspector_agent.cc‎`

Copy file name to clipboardExpand all lines: src/inspector_agent.cc

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -652,7 +652,7 @@ class NodeInspectorClient : public V8InspectorClient {`
`652`	`652`	`ToInspectorString(isolate, message->Get())->string(),`
`653`	`653`	`ToInspectorString(isolate, message->GetScriptResourceName())->string(),`
`654`	`654`	`message->GetLineNumber(context).FromMaybe(0),`
`655`		`- message->GetStartColumn(context).FromMaybe(0),`
	`655`	`+ message->GetStartColumn(),`
`656`	`656`	`client_->createStackTrace(stack_trace),`
`657`	`657`	`script_id);`
`658`	`658`	`}`

Collapse file

`‎src/node_errors.cc‎`

Copy file name to clipboardExpand all lines: src/node_errors.cc

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ static std::string GetSourceMapErrorSource(Isolate* isolate,`
`65`	`65`	`// the source texts.`
`66`	`66`	`Local<Value> script_resource_name = message->GetScriptResourceName();`
`67`	`67`	`int linenum = message->GetLineNumber(context).FromJust();`
`68`		`- int columnum = message->GetStartColumn(context).FromJust();`
	`68`	`+ int columnum = message->GetStartColumn();`
`69`	`69`
`70`	`70`	`Local<Value> argv[] = {script_resource_name,`
`71`	`71`	`v8::Int32::New(isolate, linenum),`
`@@ -148,8 +148,8 @@ static std::string GetErrorSource(Isolate* isolate,`
`148`	`148`	`int script_start = (linenum - origin.LineOffset()) == 1`
`149`	`149`	`? origin.ColumnOffset()`
`150`	`150`	`: 0;`
`151`		`- int start = message->GetStartColumn(context).FromMaybe(0);`
`152`		`- int end = message->GetEndColumn(context).FromMaybe(0);`
	`151`	`+ int start = message->GetStartColumn();`
	`152`	`+ int end = message->GetEndColumn();`
`153`	`153`	`if (start >= script_start) {`
`154`	`154`	`CHECK_GE(end, start);`
`155`	`155`	`start -= script_start;`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.