GeezerVison is showing github.com — test: skip `test-temporal-with-zoneinfo` on system-icu builds · nodejs/node@c73c8e6
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: configure.py +2Lines changed: 2 additions & 0 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -2392,6 +2392,7 @@ def icu_download(path): |
2392 | 2392 |
|
2393 | 2393 | # always set icu_small, node.gyp depends on it being defined. |
2394 | 2394 | o['variables']['icu_small'] = b(False) |
| 2395 | + o['variables']['icu_system'] = b(False) |
2395 | 2396 |
|
2396 | 2397 | # prevent data override |
2397 | 2398 | o['defines'] += ['ICU_NO_USER_DATA_OVERRIDE'] |
@@ -2428,6 +2429,7 @@ def icu_download(path): |
2428 | 2429 | o['variables']['v8_enable_i18n_support'] = 1 |
2429 | 2430 | elif with_intl == 'system-icu': |
2430 | 2431 | # ICU from pkg-config. |
| 2432 | + o['variables']['icu_system'] = b(True) |
2431 | 2433 | o['variables']['v8_enable_i18n_support'] = 1 |
2432 | 2434 | pkgicu = pkg_config(['icu-i18n', 'icu-uc']) |
2433 | 2435 | if not pkgicu[0]: |
|
Collapse file
Copy file name to clipboardExpand all lines: test/parallel/test-temporal-with-zoneinfo.js +4Lines changed: 4 additions & 0 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -12,6 +12,10 @@ if (!process.config.variables.v8_enable_temporal_support) { |
12 | 12 | if (!common.hasFullICU) { |
13 | 13 | common.skip('Time zone support unavailable when not built with full ICU'); |
14 | 14 | } |
| 15 | +// TODO(aduh95): fix zoneinfo support with system-icu. |
| 16 | +if (process.config.variables.icu_system) { |
| 17 | + common.skip('Time zone support unavailable on --with-intl=system-icu builds'); |
| 18 | +} |
15 | 19 |
|
16 | 20 | // Use globalThis.Temporal to workaround linter complaints. |
17 | 21 | assert.strictEqual(typeof globalThis.Temporal, 'object'); |
|