GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — meta: require DCO signoff in commit message guidelines · nodejs/node@ca16ad8

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

doc/contributing
- pull-requests.md

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎doc/contributing/pull-requests.md‎`

Copy file name to clipboardExpand all lines: doc/contributing/pull-requests.md

+10Lines changed: 10 additions & 0 deletions

Display the source diff
Display the rich diff

Original file line number	Diff line number	Diff line change
`@@ -199,6 +199,14 @@ A good commit message should describe what changed and why.`
`199`	`199`	`contain an explanation about the reason of the breaking change, which`
`200`	`200`	`situation would trigger the breaking change, and what is the exact change.`
`201`	`201`
	`202`	+6. Your commit must contain the `Signed-off-by` line with your name and email
	`203`	`+ address as an acknowledgement that you agree to the [Developer Certificate of Origin][].`
	`204`	`+ Bot generated commits are exempt from this requirement. If a commit has`
	`205`	+ multiple authors, the `Signed-off-by` line should be added for each author;
	`206`	`+ and at least one should match the author information in the commit metadata.`
	`207`	`+ This rule does not apply to dependency updates (e.g. cherry-picks), release`
	`208`	`+ commits, or backport commits.`
	`209`	`+`
`202`	`210`	`Sample complete commit message:`
`203`	`211`
`204`	`212`	```text
`@@ -210,6 +218,7 @@ less.`
`210`	`218`
`211`	`219`	`Fixes: https://github.com/nodejs/node/issues/1337`
`212`	`220`	`Refs: https://eslint.org/docs/rules/space-in-parens.html`
	`221`	`+Signed-off-by: J. Random User <[email protected]>`
`213`	`222`	```
`214`	`223`
`215`	`224`	`If you are new to contributing to Node.js, please try to do your best at`
`@@ -594,6 +603,7 @@ More than one subsystem may be valid for any particular issue or pull request.`
`594`	`603`	`[Building guide]: ../../BUILDING.md`
`595`	`604`	`[CI (Continuous Integration) test run]: #continuous-integration-testing`
`596`	`605`	`[Code of Conduct]: https://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md`
	`606`	`+[Developer Certificate of Origin]: ../../CONTRIBUTING.md#developers-certificate-of-origin-11`
`597`	`607`	`[Onboarding guide]: ../../onboarding.md`
`598`	`608`	`[approved]: #getting-approvals-for-your-pull-request`
`599`	`609`	`[benchmark results]: writing-and-running-benchmarks.md`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.