GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — util: fix inspecting error with a throwing getter for `cause` · nodejs/node@cbb3627

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

lib/internal/util
- inspect.js
test/message
- util-inspect-error-cause.js
- util-inspect-error-cause.out

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎lib/internal/util/inspect.js‎`

Copy file name to clipboardExpand all lines: lib/internal/util/inspect.js

+9-2Lines changed: 9 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1243,9 +1243,16 @@ function getStackString(error) {`
`1243`	`1243`	`function getStackFrames(ctx, err, stack) {`
`1244`	`1244`	`const frames = StringPrototypeSplit(stack, '\n');`
`1245`	`1245`
	`1246`	`+ let cause;`
	`1247`	`+ try {`
	`1248`	`+ ({ cause } = err);`
	`1249`	`+ } catch {`
	`1250`	`+ // If 'cause' is a getter that throws, ignore it.`
	`1251`	`+ }`
	`1252`	`+`
`1246`	`1253`	`// Remove stack frames identical to frames in cause.`
`1247`		`- if (err.cause && isError(err.cause)) {`
`1248`		`- const causeStack = getStackString(err.cause);`
	`1254`	`+ if (cause != null && isError(cause)) {`
	`1255`	`+ const causeStack = getStackString(cause);`
`1249`	`1256`	`const causeStackStart = StringPrototypeIndexOf(causeStack, '\n at');`
`1250`	`1257`	`if (causeStackStart !== -1) {`
`1251`	`1258`	`const causeFrames = StringPrototypeSplit(StringPrototypeSlice(causeStack, causeStackStart + 1), '\n');`

Collapse file

`‎test/message/util-inspect-error-cause.js‎`

Copy file name to clipboardExpand all lines: test/message/util-inspect-error-cause.js

+6Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -46,3 +46,9 @@ process.nextTick(() => {`
`46`	`46`	`console.log(inspect(cause3));`
`47`	`47`	`console.log(inspect(error2));`
`48`	`48`	`});`
	`49`	`+`
	`50`	`+{`
	`51`	`+ const error = new Error('cause that throws');`
	`52`	`+ Reflect.defineProperty(error, 'cause', { get() { throw new Error(); } });`
	`53`	`+ console.log(inspect(error));`
	`54`	`+}`

Collapse file

`‎test/message/util-inspect-error-cause.out‎`

Copy file name to clipboardExpand all lines: test/message/util-inspect-error-cause.out

+10Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,16 @@ Error: undefined cause`
`33`	`33`	`at * {`
`34`	`34`	`[cause]: undefined`
`35`	`35`	`}`
	`36`	`+Error: cause that throws`
	`37`	`+ at *`
	`38`	`+ at *`
	`39`	`+ at *`
	`40`	`+ at *`
	`41`	`+ at *`
	`42`	`+ at *`
	`43`	`+ at * {`
	`44`	`+ [cause]: [Getter]`
	`45`	`+}`
`36`	`46`	`RangeError: New Stack Frames`
`37`	`47`	`at *`
`38`	`48`	`[90m at [39m {`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.