GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — http: fixes memory retention issue with FreeList and HTTPParser · nodejs/node@cc02c73

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • lib
    • _http_common.js
  • test/parallel
    • test-http-parser-memory-retention.js
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎lib/_http_common.js‎

Copy file name to clipboardExpand all lines: lib/_http_common.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,12 +161,10 @@ const parsers = new FreeList('parsers', 1000, function parsersCb() {
161161

162162
cleanParser(parser);
163163

164-
parser.onIncoming = null;
165164
parser[kOnHeaders] = parserOnHeaders;
166165
parser[kOnHeadersComplete] = parserOnHeadersComplete;
167166
parser[kOnBody] = parserOnBody;
168167
parser[kOnMessageComplete] = parserOnMessageComplete;
169-
parser[kOnTimeout] = null;
170168

171169
return parser;
172170
});
@@ -232,7 +230,9 @@ function cleanParser(parser) {
232230
parser.outgoing = null;
233231
parser.maxHeaderPairs = MAX_HEADER_PAIRS;
234232
parser[kOnExecute] = null;
233+
parser[kOnTimeout] = null;
235234
parser._consumed = false;
235+
parser.onIncoming = null;
236236
}
237237

238238
function prepareError(err, parser, rawPacket) {
Collapse file

‎test/parallel/test-http-parser-memory-retention.js‎

Copy file name to clipboard
+42Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
'use strict';
2+
3+
const common = require('../common');
4+
const assert = require('assert');
5+
const http = require('http');
6+
const { HTTPParser } = require('_http_common');
7+
8+
// Test that the `HTTPParser` instance is cleaned up before being returned to
9+
// the pool to avoid memory retention issues.
10+
11+
const kOnTimeout = HTTPParser.kOnTimeout | 0;
12+
const server = http.createServer();
13+
14+
server.on('request', common.mustCall((request, response) => {
15+
const parser = request.socket.parser;
16+
17+
assert.strictEqual(typeof parser[kOnTimeout], 'function');
18+
19+
request.socket.on('close', common.mustCall(() => {
20+
assert.strictEqual(parser[kOnTimeout], null);
21+
}));
22+
23+
response.end();
24+
server.close();
25+
}));
26+
27+
server.listen(common.mustCall(() => {
28+
const request = http.get({ port: server.address().port });
29+
let parser;
30+
31+
request.on('socket', common.mustCall(() => {
32+
parser = request.parser;
33+
assert.strictEqual(typeof parser.onIncoming, 'function');
34+
}));
35+
36+
request.on('response', common.mustCall((response) => {
37+
response.resume();
38+
response.on('end', common.mustCall(() => {
39+
assert.strictEqual(parser.onIncoming, null);
40+
}));
41+
}));
42+
}));

0 commit comments

Comments
0 (0)
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.