GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — test: fix flaky test-http2-respond-file-error-pipe-offset · nodejs/node@cd1da67

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

test/parallel
- parallel.status
- test-http2-respond-file-error-pipe-offset.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎test/parallel/parallel.status‎`

Copy file name to clipboardExpand all lines: test/parallel/parallel.status

-2Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,8 +5,6 @@ prefix parallel`
`5`	`5`	`# sample-test : PASS,FLAKY`
`6`	`6`
`7`	`7`	`[true] # This section applies to all platforms`
`8`		`-# https://github.com/nodejs/node/issues/35881`
`9`		`-test-http2-respond-file-error-pipe-offset: PASS,FLAKY`
`10`	`8`
`11`	`9`	`[$system==win32]`
`12`	`10`	`# https://github.com/nodejs/node/issues/20750`

Collapse file

`‎test/parallel/test-http2-respond-file-error-pipe-offset.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-http2-respond-file-error-pipe-offset.js

+8-1Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -56,4 +56,11 @@ server.listen(0, () => {`
`56`	`56`	`req.end();`
`57`	`57`	`});`
`58`	`58`
`59`		`-fs.writeFile(pipeName, 'Hello, world!\n', common.mustSucceed());`
	`59`	`+fs.writeFile(pipeName, 'Hello, world!\n', common.mustCall((err) => {`
	`60`	`+ // It's possible for the reading end of the pipe to get the expected error`
	`61`	+ // and break everything down before we're finished, so allow `EPIPE` but
	`62`	`+ // no other errors.`
	`63`	`+ if (err?.code !== 'EPIPE') {`
	`64`	`+ assert.ifError(err);`
	`65`	`+ }`
	`66`	`+}));`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.