GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — test: fix flaky test-http-set-timeout-server · nodejs/node@cd98f5d

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

test/parallel
- test-http-set-timeout-server.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎test/parallel/test-http-set-timeout-server.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-http-set-timeout-server.js

+8-3Lines changed: 8 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -117,20 +117,25 @@ test(function serverRequestNotTimeoutAfterEnd(cb) {`
`117`	`117`
`118`	`118`	`test(function serverResponseTimeoutWithPipeline(cb) {`
`119`	`119`	`let caughtTimeout = '';`
	`120`	`+ let secReceived = false;`
`120`	`121`	`process.on('exit', function() {`
`121`	`122`	`assert.strictEqual(caughtTimeout, '/2');`
`122`	`123`	`});`
`123`	`124`	`const server = http.createServer(function(req, res) {`
	`125`	`+ if (req.url === '/2')`
	`126`	`+ secReceived = true;`
`124`	`127`	`const s = res.setTimeout(50, function() {`
`125`	`128`	`caughtTimeout += req.url;`
`126`	`129`	`});`
`127`	`130`	`assert.ok(s instanceof http.OutgoingMessage);`
`128`	`131`	`if (req.url === '/1') res.end();`
`129`	`132`	`});`
`130`	`133`	`server.on('timeout', function(socket) {`
`131`		`- socket.destroy();`
`132`		`- server.close();`
`133`		`- cb();`
	`134`	`+ if (secReceived) {`
	`135`	`+ socket.destroy();`
	`136`	`+ server.close();`
	`137`	`+ cb();`
	`138`	`+ }`
`134`	`139`	`});`
`135`	`140`	`server.listen(common.mustCall(function() {`
`136`	`141`	`const port = server.address().port;`

0 commit comments

Comments

0 (0)

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.