GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: remove unnecessary todo · nodejs/node@ce37688

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • src
    • node_file.cc
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/node_file.cc‎

Copy file name to clipboardExpand all lines: src/node_file.cc
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2116,7 +2116,6 @@ static inline Maybe<void> CheckOpenPermissions(Environment* env,
21162116
const int write_as_side_effect = flags & (UV_FS_O_APPEND | UV_FS_O_CREAT |
21172117
UV_FS_O_TRUNC | UV_FS_O_TEMPORARY);
21182118

2119-
// TODO(rafaelgss): it can be optimized to avoid two permission checks
21202119
auto pathView = path.ToStringView();
21212120
if (rwflags != UV_FS_O_WRONLY) {
21222121
THROW_IF_INSUFFICIENT_PERMISSIONS(

0 commit comments

Comments
0 (0)
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.