GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — async_hooks: clean up comments · nodejs/node@ce3866b

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
  • lib/internal
    • async_hooks.js
  • src
    • async_wrap.cc
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎lib/internal/async_hooks.js‎

Copy file name to clipboardExpand all lines: lib/internal/async_hooks.js
+12-11Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,27 +11,28 @@ const async_wrap = process.binding('async_wrap');
1111
* the various asynchronous states of the application. These are:
1212
* kExecutionAsyncId: The async_id assigned to the resource responsible for the
1313
* current execution stack.
14-
* kTriggerAsyncId: The trigger_async_id of the resource responsible for
15-
* the current execution stack.
14+
* kTriggerAsyncId: The async_id of the resource that caused (or 'triggered')
15+
* the resource corresponding to the current execution stack.
1616
* kAsyncIdCounter: Incremental counter tracking the next assigned async_id.
1717
* kDefaultTriggerAsyncId: Written immediately before a resource's constructor
18-
* that sets the value of the init()'s triggerAsyncId. The order of
19-
* retrieving the triggerAsyncId value is passing directly to the
20-
* constructor -> value set in kDefaultTriggerAsyncId -> executionAsyncId of
21-
* the current resource.
18+
* that sets the value of the init()'s triggerAsyncId. The precedence order
19+
* of retrieving the triggerAsyncId value is:
20+
* 1. the value passed directly to the constructor
21+
* 2. value set in kDefaultTriggerAsyncId
22+
* 3. executionAsyncId of the current resource.
2223
*
23-
* async_ids_fast_stack is a Float64Array that contains part of the async ID
24+
* async_ids_stack is a Float64Array that contains part of the async ID
2425
* stack. Each pushAsyncIds() call adds two doubles to it, and each
2526
* popAsyncIds() call removes two doubles from it.
2627
* It has a fixed size, so if that is exceeded, calls to the native
2728
* side are used instead in pushAsyncIds() and popAsyncIds().
2829
*/
2930
const { async_id_symbol, async_hook_fields, async_id_fields } = async_wrap;
3031
// Store the pair executionAsyncId and triggerAsyncId in a std::stack on
31-
// Environment::AsyncHooks::ids_stack_ tracks the resource responsible for the
32-
// current execution stack. This is unwound as each resource exits. In the case
33-
// of a fatal exception this stack is emptied after calling each hook's after()
34-
// callback.
32+
// Environment::AsyncHooks::async_ids_stack_ tracks the resource responsible for
33+
// the current execution stack. This is unwound as each resource exits. In the
34+
// case of a fatal exception this stack is emptied after calling each hook's
35+
// after() callback.
3536
const { pushAsyncIds: pushAsyncIds_, popAsyncIds: popAsyncIds_ } = async_wrap;
3637
// For performance reasons, only track Proimses when a hook is enabled.
3738
const { enablePromiseHook, disablePromiseHook } = async_wrap;
Collapse file

‎src/async_wrap.cc‎

Copy file name to clipboardExpand all lines: src/async_wrap.cc
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -554,12 +554,12 @@ void AsyncWrap::Initialize(Local<Object> target,
554554
// this way to allow JS and C++ to read/write each value as quickly as
555555
// possible. The fields are represented as follows:
556556
//
557-
// kAsyncUid: Maintains the state of the next unique id to be assigned.
557+
// kAsyncIdCounter: Maintains the state of the next unique id to be assigned.
558558
//
559559
// kDefaultTriggerAsyncId: Write the id of the resource responsible for a
560560
// handle's creation just before calling the new handle's constructor.
561561
// After the new handle is constructed kDefaultTriggerAsyncId is set back
562-
// to 0.
562+
// to -1.
563563
FORCE_SET_TARGET_FIELD(target,
564564
"async_id_fields",
565565
env->async_hooks()->async_id_fields().GetJSArray());

0 commit comments

Comments
0 (0)
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.