GeezerVison is showing github.com — stream: remove unnecessary check · nodejs/node@cee279c
File tree
Expand file treeCollapse file tree
Open diff view settings
Expand file treeCollapse file tree
Open diff view settings
Collapse file
Copy file name to clipboardExpand all lines: lib/internal/webstreams/util.js +9-10Lines changed: 9 additions & 10 deletions | Original file line number | Diff line number | Diff line change |
|---|
@@ -62,12 +62,11 @@ const getNonWritablePropertyDescriptor = (value) => { |
62 | 62 |
|
63 | 63 | function extractHighWaterMark(value, defaultHWM) { |
64 | 64 | if (value === undefined) return defaultHWM; |
65 | | - value = +value; |
66 | | - if (typeof value !== 'number' || |
67 | | - NumberIsNaN(value) || |
68 | | - value < 0) |
| 65 | + const coercedValue = +value; |
| 66 | + if (NumberIsNaN(coercedValue) || |
| 67 | + coercedValue < 0) |
69 | 68 | throw new ERR_INVALID_ARG_VALUE.RangeError('strategy.highWaterMark', value); |
70 | | - return value; |
| 69 | + return coercedValue; |
71 | 70 | } |
72 | 71 |
|
73 | 72 | function extractSizeAlgorithm(size) { |
@@ -159,13 +158,13 @@ function peekQueueValue(controller) { |
159 | 158 | function enqueueValueWithSize(controller, value, size) { |
160 | 159 | assert(controller[kState].queue !== undefined); |
161 | 160 | assert(controller[kState].queueTotalSize !== undefined); |
162 | | - size = +size; |
163 | | - if (typeof size !== 'number' || |
164 | | - size < 0 || |
165 | | - NumberIsNaN(size) || |
166 | | - size === Infinity) { |
| 161 | + const coercedSize = +size; |
| 162 | + if (NumberIsNaN(coercedSize) || |
| 163 | + coercedSize < 0 || |
| 164 | + coercedSize === Infinity) { |
167 | 165 | throw new ERR_INVALID_ARG_VALUE.RangeError('size', size); |
168 | 166 | } |
| 167 | + size = coercedSize; |
169 | 168 | ArrayPrototypePush(controller[kState].queue, { value, size }); |
170 | 169 | controller[kState].queueTotalSize += size; |
171 | 170 | } |
|