GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — http: don't emit 'finish' after 'error' · nodejs/node@cf47bb9

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

lib
- _http_outgoing.js
test/parallel
- test-tls-set-secure-context.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎lib/_http_outgoing.js‎`

Copy file name to clipboardExpand all lines: lib/_http_outgoing.js

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -727,6 +727,7 @@ OutgoingMessage.prototype.addTrailers = function addTrailers(headers) {`
`727`	`727`	`};`
`728`	`728`
`729`	`729`	`function onFinish(outmsg) {`
	`730`	`+ if (outmsg && outmsg.socket && outmsg.socket._hadError) return;`
`730`	`731`	`outmsg.emit('finish');`
`731`	`732`	`}`
`732`	`733`

Collapse file

`‎test/parallel/test-tls-set-secure-context.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-tls-set-secure-context.js

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -82,6 +82,7 @@ function makeRequest(port, id) {`
`82`	`82`	`headers: { id }`
`83`	`83`	`};`
`84`	`84`
	`85`	`+ let errored = false;`
`85`	`86`	https.get(`https://localhost:${port}`, options, (res) => {
`86`	`87`	`let response = '';`
`87`	`88`
`@@ -95,7 +96,10 @@ function makeRequest(port, id) {`
`95`	`96`	`resolve(response);`
`96`	`97`	`}));`
`97`	`98`	`}).on('error', (err) => {`
	`99`	`+ errored = true;`
`98`	`100`	`reject(err);`
	`101`	`+ }).on('finish', () => {`
	`102`	`+ assert.strictEqual(errored, false);`
`99`	`103`	`});`
`100`	`104`	`});`
`101`	`105`	`}`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.