GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — http2: validate initialWindowSize per HTTP/2 spec · nodejs/node@cf56327

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

lib/internal/http2
- core.js
test/parallel
- test-http2-getpackedsettings.js
- test-http2-session-settings.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎lib/internal/http2/core.js‎`

Copy file name to clipboardExpand all lines: lib/internal/http2/core.js

+3-2Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -230,6 +230,7 @@ function debugSessionObj(session, message, ...args) {`
`230`	`230`
`231`	`231`	`const kMaxFrameSize = (2 ** 24) - 1;`
`232`	`232`	`const kMaxInt = (2 ** 32) - 1;`
	`233`	`+const kMaxInitialWindowSize = (2 ** 31) - 1; // HTTP/2 spec maximum`
`233`	`234`	`const kMaxStreams = (2 ** 32) - 1;`
`234`	`235`	`const kMaxALTSVC = (2 ** 14) - 2;`
`235`	`236`
`@@ -989,7 +990,7 @@ function pingCallback(cb) {`
`989`	`990`
`990`	`991`	`// Validates the values in a settings object. Specifically:`
`991`	`992`	`// 1. headerTableSize must be a number in the range 0 <= n <= kMaxInt`
`992`		`-// 2. initialWindowSize must be a number in the range 0 <= n <= kMaxInt`
	`993`	`+// 2. initialWindowSize must be a number in the range 0 <= n <= 2^31-1`
`993`	`994`	`// 3. maxFrameSize must be a number in the range 16384 <= n <= kMaxFrameSize`
`994`	`995`	`// 4. maxConcurrentStreams must be a number in the range 0 <= n <= kMaxStreams`
`995`	`996`	`// 5. maxHeaderListSize must be a number in the range 0 <= n <= kMaxInt`
`@@ -1014,7 +1015,7 @@ const validateSettings = hideStackFrames((settings) => {`
`1014`	`1015`	`0, kMaxInt);`
`1015`	`1016`	`assertWithinRange.withoutStackTrace('initialWindowSize',`
`1016`	`1017`	`settings.initialWindowSize,`
`1017`		`- 0, kMaxInt);`
	`1018`	`+ 0, kMaxInitialWindowSize);`
`1018`	`1019`	`assertWithinRange.withoutStackTrace('maxFrameSize',`
`1019`	`1020`	`settings.maxFrameSize,`
`1020`	`1021`	`16384, kMaxFrameSize);`

Collapse file

`‎test/parallel/test-http2-getpackedsettings.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-http2-getpackedsettings.js

+3-1Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ assert.deepStrictEqual(val, check);`
`20`	`20`	`['headerTableSize', 0],`
`21`	`21`	`['headerTableSize', 2 ** 32 - 1],`
`22`	`22`	`['initialWindowSize', 0],`
`23`		`- ['initialWindowSize', 2 ** 32 - 1],`
	`23`	`+ ['initialWindowSize', 2 ** 31 - 1], // Max per HTTP/2 spec`
`24`	`24`	`['maxFrameSize', 16384],`
`25`	`25`	`['maxFrameSize', 2 ** 24 - 1],`
`26`	`26`	`['maxConcurrentStreams', 0],`
`@@ -42,6 +42,8 @@ http2.getPackedSettings({ enablePush: false });`
`42`	`42`	`['headerTableSize', -1],`
`43`	`43`	`['headerTableSize', 2 ** 32],`
`44`	`44`	`['initialWindowSize', -1],`
	`45`	`+ ['initialWindowSize', 2 ** 31], // Max per HTTP/2 spec is 2^31-1`
	`46`	`+ ['initialWindowSize', 2 ** 32 - 1], // Regression test for nghttp2 crash`
`45`	`47`	`['initialWindowSize', 2 ** 32],`
`46`	`48`	`['maxFrameSize', 16383],`
`47`	`49`	`['maxFrameSize', 2 ** 24],`

Collapse file

`‎test/parallel/test-http2-session-settings.js‎`

Copy file name to clipboardExpand all lines: test/parallel/test-http2-session-settings.js

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -133,6 +133,8 @@ server.listen(`
`133`	`133`	`['headerTableSize', -1],`
`134`	`134`	`['headerTableSize', 2 ** 32],`
`135`	`135`	`['initialWindowSize', -1],`
	`136`	`+ ['initialWindowSize', 2 ** 31], // Max per HTTP/2 spec is 2^31-1`
	`137`	`+ ['initialWindowSize', 2 ** 32 - 1], // Regression test for nghttp2 crash`
`136`	`138`	`['initialWindowSize', 2 ** 32],`
`137`	`139`	`['maxFrameSize', 16383],`
`138`	`140`	`['maxFrameSize', 2 ** 24],`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.