GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — src: annotate BaseObjects in the heap snapshots correctly · nodejs/node@cfb39b9

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎src/base_object-inl.h‎`

Copy file name to clipboardExpand all lines: src/base_object-inl.h

-5Lines changed: 0 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -125,11 +125,6 @@ bool BaseObject::IsWeakOrDetached() const {`
`125`	`125`	`return pd->wants_weak_jsobj \|\| pd->is_detached;`
`126`	`126`	`}`
`127`	`127`
`128`		`-v8::EmbedderGraph::Node::Detachedness BaseObject::GetDetachedness() const {`
`129`		`- return IsWeakOrDetached() ? v8::EmbedderGraph::Node::Detachedness::kDetached`
`130`		`- : v8::EmbedderGraph::Node::Detachedness::kUnknown;`
`131`		`-}`
`132`		`-`
`133`	`128`	`template <int Field>`
`134`	`129`	`void BaseObject::InternalFieldGet(`
`135`	`130`	`const v8::FunctionCallbackInfo<v8::Value>& args) {`

Collapse file

`‎src/base_object.cc‎`

Copy file name to clipboardExpand all lines: src/base_object.cc

-4Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -161,10 +161,6 @@ Local<Object> BaseObject::WrappedObject() const {`
`161`	`161`	`return object();`
`162`	`162`	`}`
`163`	`163`
`164`		`-bool BaseObject::IsRootNode() const {`
`165`		`- return !persistent_handle_.IsWeak();`
`166`		`-}`
`167`		`-`
`168`	`164`	`bool BaseObject::IsNotIndicativeOfMemoryLeakAtExit() const {`
`169`	`165`	`return IsWeakOrDetached();`
`170`	`166`	`}`

Collapse file

`‎src/base_object.h‎`

Copy file name to clipboardExpand all lines: src/base_object.h

-3Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -105,8 +105,6 @@ class BaseObject : public MemoryRetainer {`
`105`	`105`	`// to it anymore.`
`106`	`106`	`inline bool IsWeakOrDetached() const;`
`107`	`107`
`108`		`- inline v8::EmbedderGraph::Node::Detachedness GetDetachedness() const override;`
`109`		`-`
`110`	`108`	`// Utility to create a FunctionTemplate with one internal field (used for`
`111`	`109`	// the `BaseObject*` pointer) and a constructor that initializes that field
`112`	`110`	// to `nullptr`.
`@@ -192,7 +190,6 @@ class BaseObject : public MemoryRetainer {`
`192`	`190`
`193`	`191`	`private:`
`194`	`192`	`v8::Local<v8::Object> WrappedObject() const override;`
`195`		`- bool IsRootNode() const override;`
`196`	`193`	`void DeleteMe();`
`197`	`194`
`198`	`195`	`// persistent_handle_ needs to be at a fixed offset from the start of the`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.