|
26 | 26 | console.log('error!: ' + err.code); |
27 | 27 | console.log('stdout: ' + JSON.stringify(stdout)); |
28 | 28 | console.log('stderr: ' + JSON.stringify(stderr)); |
29 | | - assert.equal(false, err.killed); |
| 29 | + assert.strictEqual(false, err.killed); |
30 | 30 | } else { |
31 | 31 | success_count++; |
32 | 32 | console.dir(stdout); |
@@ -38,17 +38,19 @@ exec( |
38 | 38 | exec('thisisnotavalidcommand', function(err, stdout, stderr) { |
39 | 39 | if (err) { |
40 | 40 | error_count++; |
41 | | - assert.equal('', stdout); |
42 | | - assert.equal(true, err.code != 0); |
43 | | - assert.equal(false, err.killed); |
| 41 | + assert.strictEqual('', stdout); |
| 42 | + assert.strictEqual(typeof err.code, 'number'); |
| 43 | + assert.notStrictEqual(err.code, 0); |
| 44 | + assert.strictEqual(false, err.killed); |
44 | 45 | assert.strictEqual(null, err.signal); |
45 | 46 | console.log('error code: ' + err.code); |
46 | 47 | console.log('stdout: ' + JSON.stringify(stdout)); |
47 | 48 | console.log('stderr: ' + JSON.stringify(stderr)); |
48 | 49 | } else { |
49 | 50 | success_count++; |
50 | 51 | console.dir(stdout); |
51 | | - assert.equal(true, stdout != ''); |
| 52 | + assert.strictEqual(typeof stdout, 'string'); |
| 53 | + assert.notStrictEqual(stdout, ''); |
52 | 54 | } |
53 | 55 | }); |
54 | 56 |
|
@@ -60,7 +62,7 @@ exec(SLEEP3_COMMAND, { timeout: 50 }, function(err, stdout, stderr) { |
60 | 62 | assert.ok(diff < 500); |
61 | 63 | assert.ok(err); |
62 | 64 | assert.ok(err.killed); |
63 | | - assert.equal(err.signal, 'SIGTERM'); |
| 65 | + assert.strictEqual(err.signal, 'SIGTERM'); |
64 | 66 | }); |
65 | 67 |
|
66 | 68 |
|
@@ -71,7 +73,7 @@ process.nextTick(function() { |
71 | 73 | console.log('kill pid %d', killMeTwice.pid); |
72 | 74 | // make sure there is no race condition in starting the process |
73 | 75 | // the PID SHOULD exist directly following the exec() call. |
74 | | - assert.equal('number', typeof killMeTwice._handle.pid); |
| 76 | + assert.strictEqual('number', typeof killMeTwice._handle.pid); |
75 | 77 | // Kill the process |
76 | 78 | killMeTwice.kill(); |
77 | 79 | }); |
@@ -82,7 +84,7 @@ function killMeTwiceCallback(err, stdout, stderr) { |
82 | 84 | // works and that we are getting the proper callback parameters. |
83 | 85 | assert.ok(err); |
84 | 86 | assert.ok(err.killed); |
85 | | - assert.equal(err.signal, 'SIGTERM'); |
| 87 | + assert.strictEqual(err.signal, 'SIGTERM'); |
86 | 88 |
|
87 | 89 | // the timeout should still be in effect |
88 | 90 | console.log('\'sleep 3\' was already killed. Took %d ms', diff); |
@@ -98,6 +100,6 @@ exec('python -c "print 200000*\'C\'"', {maxBuffer: 1000}, |
98 | 100 |
|
99 | 101 |
|
100 | 102 | process.on('exit', function() { |
101 | | - assert.equal(1, success_count); |
102 | | - assert.equal(1, error_count); |
| 103 | + assert.strictEqual(1, success_count); |
| 104 | + assert.strictEqual(1, error_count); |
103 | 105 | }); |