GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — doc: add ReflectConstruct to known perf issues · nodejs/node@d4659e2

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

doc/contributing
- primordials.md

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎doc/contributing/primordials.md‎`

Copy file name to clipboardExpand all lines: doc/contributing/primordials.md

+3Lines changed: 3 additions & 0 deletions

Display the source diff
Display the rich diff

Original file line number	Diff line number	Diff line change
`@@ -122,6 +122,9 @@ performance of code in Node.js.`
`122`	`122`	* `SafePromiseAny`
`123`	`123`	* `SafePromiseRace`
`124`	`124`	* `SafePromisePrototypeFinally`: use `try {} finally {}` block instead.
	`125`	+* `ReflectConstruct`: Also affects `Reflect.construct`.
	`126`	+ `ReflectConstruct` creates new types of classes inside functions.
	`127`	`+ Instead consider creating a shared class. See [nodejs/performance#109](https://github.com/nodejs/performance/issues/109).`
`125`	`128`
`126`	`129`	`In general, when sending or reviewing a PR that makes changes in a hot code`
`127`	`130`	`path, use extra caution and run extensive benchmarks.`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.