GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — build,tools: fix addon build deadlock on errors · nodejs/node@d597b8e

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

tools
- build_addons.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎tools/build_addons.py‎`

Copy file name to clipboardExpand all lines: tools/build_addons.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -58,8 +58,8 @@ def node_gyp_rebuild(test_dir):`
`58`	`58`
`59`	`59`	`# We buffer the output and print it out once the process is done in order`
`60`	`60`	`# to avoid interleaved output from multiple builds running at once.`
`61`		`- return_code = process.wait()`
`62`	`61`	`stdout, stderr = process.communicate()`
	`62`	`+ return_code = process.returncode`
`63`	`63`	`if return_code != 0:`
`64`	`64`	`print(f'Failed to build addon in {test_dir}:')`
`65`	`65`	`if stdout:`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.