GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — doc: document and warn if the ICU version is too old · nodejs/node@db113a2

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

BUILDING.md
configure.py
tools/icu
- icu_versions.json

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎BUILDING.md‎`

Copy file name to clipboardExpand all lines: BUILDING.md

+4Lines changed: 4 additions & 0 deletions

Display the source diff
Display the rich diff

Original file line number	Diff line number	Diff line change
`@@ -470,6 +470,10 @@ You can find other ICU releases at`
`470`	`470`	Download the file named something like `icu4c-##.#-src.tgz` (or
`471`	`471`	`.zip`).
`472`	`472`
	`473`	+To check the minimum recommended ICU, run `./configure --help` and see
	`474`	+the help for the `--with-icu-source` option. A warning will be printed
	`475`	`+during configuration if the ICU version is too old.`
	`476`	`+`
`473`	`477`	`##### Unix/macOS`
`474`	`478`
`475`	`479`	`From an already-unpacked ICU:`

Collapse file

`‎configure.py‎`

Copy file name to clipboardExpand all lines: configure.py

+8-1Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,8 @@`
`51`	`51`	`valid_mips_fpu = ('fp32', 'fp64', 'fpxx')`
`52`	`52`	`valid_mips_float_abi = ('soft', 'hard')`
`53`	`53`	`valid_intl_modes = ('none', 'small-icu', 'full-icu', 'system-icu')`
	`54`	`+with open ('tools/icu/icu_versions.json') as f:`
	`55`	`+ icu_versions = json.load(f)`
`54`	`56`
`55`	`57`	`# create option groups`
`56`	`58`	`shared_optgroup = optparse.OptionGroup(parser, "Shared libraries",`
`@@ -425,7 +427,9 @@`
`425`	`427`	`intl_optgroup.add_option('--with-icu-source',`
`426`	`428`	`action='store',`
`427`	`429`	`dest='with_icu_source',`
`428`		`- help='Intl mode: optional local path to icu/ dir, or path/URL of icu source archive.')`
	`430`	`+ help='Intl mode: optional local path to icu/ dir, or path/URL of '`
	`431`	`+ 'the icu4c source archive. '`
	`432`	`+ 'v%d.x or later recommended.' % icu_versions["minimum_icu"])`
`429`	`433`
`430`	`434`	`parser.add_option('--with-ltcg',`
`431`	`435`	`action='store_true',`
`@@ -1452,6 +1456,9 @@ def write_config(data, name):`
`1452`	`1456`	`icu_ver_major = m.group(1)`
`1453`	`1457`	`if not icu_ver_major:`
`1454`	`1458`	`error('Could not read U_ICU_VERSION_SHORT version from %s' % uvernum_h)`
	`1459`	`+ elif int(icu_ver_major) < icu_versions["minimum_icu"]:`
	`1460`	`+ error('icu4c v%d.x is too old, v%d.x or later is required.' % (int(icu_ver_major),`
	`1461`	`+ icu_versions["minimum_icu"]))`
`1455`	`1462`	`icu_endianness = sys.byteorder[0];`
`1456`	`1463`	`o['variables']['icu_ver_major'] = icu_ver_major`
`1457`	`1464`	`o['variables']['icu_endianness'] = icu_endianness`

Collapse file

`‎tools/icu/icu_versions.json‎`

Copy file name to clipboard

+3Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+{`
	`2`	`+ "minimum_icu": 57`
	`3`	`+}`

0 commit comments

Comments

0 (0)

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.