GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — buffer: improve byteLength performance · nodejs/node@dc22890

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

src
- node_buffer.cc
- node_external_reference.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

`‎src/node_buffer.cc‎`

Copy file name to clipboardExpand all lines: src/node_buffer.cc

+18-6Lines changed: 18 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -728,16 +728,28 @@ void SlowByteLengthUtf8(const FunctionCallbackInfo<Value>& args) {`
`728`	`728`	`args.GetReturnValue().Set(args[0].As<String>()->Utf8Length(env->isolate()));`
`729`	`729`	`}`
`730`	`730`
`731`		`-uint32_t FastByteLengthUtf8(Local<Value> receiver,`
`732`		`- const v8::FastOneByteString& source) {`
	`731`	`+uint32_t FastByteLengthUtf8(`
	`732`	`+ Local<Value> receiver,`
	`733`	`+ Local<Value> sourceValue,`
	`734`	`+ v8::FastApiCallbackOptions& options) { // NOLINT(runtime/references)`
	`735`	`+ TRACK_V8_FAST_API_CALL("Buffer::FastByteLengthUtf8");`
	`736`	`+ auto isolate = options.isolate;`
	`737`	`+ HandleScope handleScope(isolate);`
	`738`	`+ CHECK(sourceValue->IsString());`
	`739`	`+ Local<String> sourceStr = sourceValue.As<String>();`
	`740`	`+`
	`741`	`+ if (!sourceStr->IsExternalOneByte()) {`
	`742`	`+ return sourceStr->Utf8Length(isolate);`
	`743`	`+ }`
	`744`	`+ auto source = sourceStr->GetExternalOneByteStringResource();`
`733`	`745`	`// For short inputs, the function call overhead to simdutf is maybe`
`734`	`746`	`// not worth it, reserve simdutf for long strings.`
`735`		`- if (source.length > 128) {`
`736`		`- return simdutf::utf8_length_from_latin1(source.data, source.length);`
	`747`	`+ if (source->length() > 128) {`
	`748`	`+ return simdutf::utf8_length_from_latin1(source->data(), source->length());`
`737`	`749`	`}`
`738`	`750`
`739`		`- uint32_t length = source.length;`
`740`		`- const auto input = reinterpret_cast<const uint8_t*>(source.data);`
	`751`	`+ uint32_t length = source->length();`
	`752`	`+ const auto input = reinterpret_cast<const uint8_t*>(source->data());`
`741`	`753`
`742`	`754`	`uint32_t answer = length;`
`743`	`755`	`uint32_t i = 0;`

Collapse file

`‎src/node_external_reference.h‎`

Copy file name to clipboardExpand all lines: src/node_external_reference.h

+6Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,11 @@ using CFunctionCallbackWithMultipleValueAndOptions =`
`17`	`17`	`v8::Local<v8::Value>,`
`18`	`18`	`v8::Local<v8::Value>,`
`19`	`19`	`v8::FastApiCallbackOptions&);`
	`20`	`+using CFunctionA =`
	`21`	`+ uint32_t (*)(v8::Local<v8::Value> receiver,`
	`22`	`+ v8::Local<v8::Value> sourceValue,`
	`23`	`+ // NOLINTNEXTLINE(runtime/references) This is V8 api.`
	`24`	`+ v8::FastApiCallbackOptions& options);`
`20`	`25`	`using CFunctionCallbackWithOneByteString =`
`21`	`26`	`uint32_t (*)(v8::Local<v8::Value>, const v8::FastOneByteString&);`
`22`	`27`
`@@ -98,6 +103,7 @@ class ExternalReferenceRegistry {`
`98`	`103`	`ExternalReferenceRegistry();`
`99`	`104`
`100`	`105`	`#define ALLOWED_EXTERNAL_REFERENCE_TYPES(V) \`
	`106`	`+ V(CFunctionA) \`
`101`	`107`	`V(CFunctionCallback) \`
`102`	`108`	`V(CFunctionCallbackWithalueAndOptions) \`
`103`	`109`	`V(CFunctionCallbackWithMultipleValueAndOptions) \`

0 commit comments

Comments

0 (0)

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.